From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755971AbbI0OX3 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Sep 2015 10:23:29 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:38303 "EHLO
	mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755782AbbI0OX1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Sep 2015 10:23:27 -0400
Subject: Re: [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
To: fan.chen@mediatek.com, Mark Rutland <mark.rutland@arm.com>
References: <1440727919-34719-1-git-send-email-fan.chen@mediatek.com>
Cc: srv_heupstream@mediatek.com, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Daniel Kurtz <djkurtz@chromium.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Eddie Huang <eddie.huang@mediatek.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Howard Chen <howard.chen@linaro.org>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>
From: Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <5607FBDB.2070201@gmail.com>
Date: Sun, 27 Sep 2015 16:23:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1440727919-34719-1-git-send-email-fan.chen@mediatek.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 28/08/15 04:11, fan.chen@mediatek.com wrote:
> From: Fan Chen <fan.chen@mediatek.com>
>
> This patch adds psci comatible properties to support all mandatory
> functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
> can be supported in PSCI-1.0.
>
> Signed-off-by: Fan Chen <fan.chen@mediatek.com>
> ---
> Because PSCI-1.0 patches hadn't landed on mainline, this patch is
> based on three patch sets below:
> [0] http://www.spinics.net/lists/arm-kernel/msg425793.html
>      PSCI: system suspend support
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
>      psci/unification
> [2] http://www.spinics.net/lists/devicetree/msg82017.html
>      [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support
>
> Before they are merged in, this patch still works fine with psci-0.2
> support in current mainline.
> ---
>   arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..b9b4205 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -95,7 +95,7 @@
>   	};
>
>   	psci {
> -		compatible = "arm,psci";
> +		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";

As this binding is not yet upstream, I prefer not to take the patch. 
Most probably the binding will have the name you indicated, but as DTS 
bindings are representing an external API, we should be really careful 
in changing them.

Cheers,
Matthias

>   		method = "smc";
>   		cpu_suspend   = <0x84000001>;
>   		cpu_off	      = <0x84000002>;
>