Re: [PATCH 03/34] selftests: clone3: Fix incorrect kernel headers search path

Christian Brauner
2023-01-30T16:26:46Z

On Mon, Jan 30, 2023 at 09:15:13AM -0700, Shuah Khan wrote:
> On 1/27/23 06:57, Mathieu Desnoyers wrote:
> > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
> > building against kernel headers from the build environment in scenarios
> > where kernel headers are installed into a specific output directory
> > (O=...).
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > Cc: Shuah Khan <shuah@kernel.org>
> > Cc: linux-kselftest@vger.kernel.org
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: <stable@vger.kernel.org> [5.18+]
> > ---

Looks good to me,
Acked-by: Christian Brauner <brauner@kernel.org>

> > tools/testing/selftests/clone3/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile
> > index 79b19a2863a0..84832c369a2e 100644
> > --- a/tools/testing/selftests/clone3/Makefile
> > +++ b/tools/testing/selftests/clone3/Makefile
> > @@ -1,5 +1,5 @@
> > # SPDX-License-Identifier: GPL-2.0
> > -CFLAGS += -g -std=gnu99 -I../../../../usr/include/
> > +CFLAGS += -g -std=gnu99 $(KHDR_INCLUDES)
> > LDLIBS += -lcap
> > TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \
>
> + brauner@kernel.org
>
> Hi Christian,

Hey Shuah,

>
> Would you me to take this patch through kselftest tree? If you

Feel free to take it through the kselftest tree. Thank you!
Christian