From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756731AbbI1HiE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 03:38:04 -0400
Received: from lucky1.263xmail.com ([211.157.147.133]:59040 "EHLO
	lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750864AbbI1HiB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 03:38:01 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-ADDR-CHECKED: 0
X-RL-SENDER: shawn.lin@rock-chips.com
X-FST-TO: jason.wu@spreadtrum.com
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: shawn.lin@rock-chips.com
X-UNIQUE-TAG: <d29ba24acb087dd6eaf7643f5e988d21>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum
 SoC
To: Hongtao Wu <wuht06@gmail.com>
References: <1439571353-30165-1-git-send-email-wuht06@gmail.com>
 <1439571353-30165-2-git-send-email-wuht06@gmail.com>
 <CAPDyKFp=XH+Vo_diRyhrMuB+v1rmTmxo3Lid3Wc-u1ohqNisKw@mail.gmail.com>
 <CAG_R4_VTXCV4NVMOwv-9F56-_pVsK0hU4go79ZhV3OFxwcF0mA@mail.gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, shawn.lin@rock-chips.com,
        linux-mmc <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?Q?Pawe=c5=82_Moll?= <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "Orson.Zhai@spreadtrum.com" <Orson.Zhai@spreadtrum.com>,
        "Chunyan.Zhang@spreadtrum.com" <Chunyan.Zhang@spreadtrum.com>,
        "Jason.Wu@spreadtrum.com" <Jason.Wu@spreadtrum.com>
From: Shawn Lin <shawn.lin@rock-chips.com>
Message-ID: <5608EE47.1020402@rock-chips.com>
Date: Mon, 28 Sep 2015 15:37:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CAG_R4_VTXCV4NVMOwv-9F56-_pVsK0hU4go79ZhV3OFxwcF0mA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/9/28 15:18, Hongtao Wu wrote:
>  >>
>
> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson <ulf.hansson@linaro.org
> <mailto:ulf.hansson@linaro.org>> wrote:
>  >
>  > On 14 August 2015 at 18:55, Hongtao Wu <wuht06@gmail.com
> <mailto:wuht06@gmail.com>> wrote:

[...]

>
> Yes, most of this data can be removed, such as caps, caps2, base_clk.
> However ocr_avail and signal_default_voltage are useful for us.
> We can't fetch ocr_avail from external regulator via
> mmc_regulator_get_supply,
> because our regulator driver can't supply mmc_regulator_get_ocrmask()
> interface for MMC driver.

Sorry for the noise but... IMO, your need to quirk your regulator driver 
stuffs rather than mmc.

> And sometimes our external regulator can not supply 3.0v or 1.8v default
> signal voltage that we expect. So this 3.0v or 1.8v default signal
> voltage are
> mandatory.
>



-- 
Best Regards
Shawn Lin