From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757463AbbI1NVG (ORCPT ); Mon, 28 Sep 2015 09:21:06 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:33485 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754876AbbI1NVD (ORCPT ); Mon, 28 Sep 2015 09:21:03 -0400 Reply-To: alex.popov@linux.com Subject: Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO References: <1443115737-3948-1-git-send-email-alex.popov@linux.com> <1443115737-3948-3-git-send-email-alex.popov@linux.com> <560492C1.307@tabi.org> To: Timur Tabi , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anatolij Gustschin , Gerhard Sittig , Rob Herring , Grant Likely , Dan Williams , Vinod Koul , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Alexander Popov X-Enigmail-Draft-Status: N1110 Message-ID: <56093F89.1020004@linux.com> Date: Mon, 28 Sep 2015 16:24:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <560492C1.307@tabi.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.09.2015 03:18, Timur Tabi wrote: > Alexander Popov wrote: >> +- dma-names: should be "rx-tx"; > > Why bother, if it can only be one value? I've just followed devicetree/bindings/dma/dma.txt... This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO uses a single DMA read-write channel. Should I really drop it? Best regards, Alexander