From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934064AbbI1PNp (ORCPT ); Mon, 28 Sep 2015 11:13:45 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61702 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933554AbbI1PNo (ORCPT ); Mon, 28 Sep 2015 11:13:44 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ff-560959253c25 Message-id: <56095923.7090600@samsung.com> Date: Mon, 28 Sep 2015 17:13:39 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: linux-leds@vger.kernel.org Cc: Jacek Anaszewski , linux-kernel@vger.kernel.org, sakari.ailus@linux.intel.com, andrew@lunn.ch, rpurdie@rpsys.net Subject: Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently References: <1443445641-9529-1-git-send-email-j.anaszewski@samsung.com> <1443445641-9529-2-git-send-email-j.anaszewski@samsung.com> In-reply-to: <1443445641-9529-2-git-send-email-j.anaszewski@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xa7qqkZxhBqu2Mlmcv3uI2aL36nNG i8u75rBZbH2zjtFi966nrBaftnxjcmDzmHcy0GPnjs9MHnvm/2D16NuyitHj8ya5ANYoLpuU 1JzMstQifbsEroxP64+zFqzjr7g+fS9bA+MDni5GTg4JAROJi38/sULYYhIX7q1n62Lk4hAS WMoocfzNZGYI5xmjxOHL91lAqngFtCSu3r/J2MXIwcEioCrROjkbJMwmYCjx88VrJhBbVCBC 4s/pfawQ5YISPybfYwEpFxGQk9h5phJkJLPABEaJDVfWgNUIC/hIrNq2jRFiVyujxKKONjaQ BKeAh8SCrhawImYBa4mVk0CKQGx5ic1r3jJPYBSYhWTHLCRls5CULWBkXsUomlqaXFCclJ5r pFecmFtcmpeul5yfu4kREtpfdzAuPWZ1iFGAg1GJh3emOkeYEGtiWXFl7iFGCQ5mJRHerb6c YUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg1C8PSn9y YYoEs6D8fO64YyYzfRb4bHxw6uMBKcOOC8bbD4YbN361Np12o3ZT3C2z4lktxXty9ixVSA6N evyy31pcMDD01LmHDjtVS5rKv4mIn3nWuHxr4jnjcBtvxpBSJ/GD98xnvN7xYUuYBY+77pVS nlkdAnHqSxPaqjVSv+S0tbm8OKuhxFKckWioxVxUnAgA6gq4wWkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch isn't going to be applied since it can cause legal implications for existing users. On 09/28/2015 03:07 PM, Jacek Anaszewski wrote: > LED core has a mixture of EXPORT_SYMBOL and EXPORT_SYMBOL_GPL macros. > This patch fixes this discrepancy and switches to using EXPORT_SYMBOL_GPL > for each exported function. > > Signed-off-by: Jacek Anaszewski > --- > drivers/leds/led-core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 549de7e..c1dd545 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -83,7 +83,7 @@ void led_blink_set(struct led_classdev *led_cdev, > > led_blink_setup(led_cdev, delay_on, delay_off); > } > -EXPORT_SYMBOL(led_blink_set); > +EXPORT_SYMBOL_GPL(led_blink_set); > > void led_blink_set_oneshot(struct led_classdev *led_cdev, > unsigned long *delay_on, > @@ -104,7 +104,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev, > > led_blink_setup(led_cdev, delay_on, delay_off); > } > -EXPORT_SYMBOL(led_blink_set_oneshot); > +EXPORT_SYMBOL_GPL(led_blink_set_oneshot); > > void led_stop_software_blink(struct led_classdev *led_cdev) > { > @@ -139,7 +139,7 @@ void led_set_brightness(struct led_classdev *led_cdev, > dev_dbg(led_cdev->dev, "Setting LED brightness failed (%d)\n", > ret); > } > -EXPORT_SYMBOL(led_set_brightness); > +EXPORT_SYMBOL_GPL(led_set_brightness); > > int led_update_brightness(struct led_classdev *led_cdev) > { > @@ -155,7 +155,7 @@ int led_update_brightness(struct led_classdev *led_cdev) > > return ret; > } > -EXPORT_SYMBOL(led_update_brightness); > +EXPORT_SYMBOL_GPL(led_update_brightness); > > /* Caller must ensure led_cdev->led_access held */ > void led_sysfs_disable(struct led_classdev *led_cdev) > -- Best Regards, Jacek Anaszewski