From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754915AbbI2Bm1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 21:42:27 -0400
Received: from nasmtp01.atmel.com ([192.199.1.246]:8478 "EHLO
	DVREDG02.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754757AbbI2BmZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 21:42:25 -0400
Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci
 warnings
To: Peter Korsgaard <peter@korsgaard.com>, kbuild test robot <lkp@intel.com>
References: <201509281735.7lYs3Huz%fengguang.wu@intel.com>
 <20150928091029.GA23312@roam> <874miekcnd.fsf@dell.be.48ers.dk>
CC: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>, <nicolas.ferre@atmel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <kbuild-all@01.org>, <linux-arm-kernel@lists.infradead.org>
From: "Wu, Songjun" <songjun.wu@atmel.com>
Organization: ATMEL
Message-ID: <5609EC76.1070109@atmel.com>
Date: Tue, 29 Sep 2015 09:42:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <874miekcnd.fsf@dell.be.48ers.dk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 9/28/2015 19:26, Peter Korsgaard wrote:
>>>>>> "kbuild" == kbuild test robot <lkp@intel.com> writes:
>
>   > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
>   >  PTR_ERR should access the value just tested by IS_ERR
>
>   > Semantic patch information:
>   >  There can be false positives in the patch case, where it is the call
>   >  IS_ERR that is wrong.
>
>   > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
>   > CC: Songjun Wu <songjun.wu@atmel.com>
>   > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>   > ---
>
>   >  atmel-classd.c |    2 +-
>   >  1 file changed, 1 insertion(+), 1 deletion(-)
>
>   > --- a/sound/soc/atmel/atmel-classd.c
>   > +++ b/sound/soc/atmel/atmel-classd.c
>   > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
>
>   dd-> gclk = devm_clk_get(dev, "gclk");
>   >  	if (IS_ERR(dd->aclk)) {
>   > -		ret = PTR_ERR(dd->gclk);
>   > +		ret = PTR_ERR(dd->aclk);
>
> It looks like it is the other way around. It should test
> IS_ERR(dd->gclk) instead.
>
Thank you, you are right.
It should test IS_ERR(dd->gclk) instead.