From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933995AbbI2IoQ (ORCPT ); Tue, 29 Sep 2015 04:44:16 -0400 Received: from smtp-out-080.synserver.de ([212.40.185.80]:1123 "EHLO smtp-out-050.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933619AbbI2Ing (ORCPT ); Tue, 29 Sep 2015 04:43:36 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 22376 Message-ID: <560A4EF7.9030506@metafoo.de> Date: Tue, 29 Sep 2015 10:42:31 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Cyrille Pitchen , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ASoC: ad193x: add support to ad1934 References: <273ce440257bbe7c450132bd8dffb25cbaac117e.1443515024.git.cyrille.pitchen@atmel.com> In-Reply-To: <273ce440257bbe7c450132bd8dffb25cbaac117e.1443515024.git.cyrille.pitchen@atmel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/2015 10:36 AM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly > different from the register mapping of other members of the AD193x family. > > Some ASoC controls and widgets are related to the DAC feature so are not > relevant in the case of an AD1934 codec. Looks mostly good, thanks. > diff --git a/sound/soc/codecs/ad193x-i2c.c b/sound/soc/codecs/ad193x-i2c.c > index df3a1a415825..8aa50d35662f 100644 > --- a/sound/soc/codecs/ad193x-i2c.c > +++ b/sound/soc/codecs/ad193x-i2c.c > @@ -15,8 +15,8 @@ > #include "ad193x.h" > > static const struct i2c_device_id ad193x_id[] = { > - { "ad1936", 0 }, > - { "ad1937", 0 }, > + { "ad1936", AD193x }, > + { "ad1937", AD193x }, Should be a upper case X. > { } > }; [...] [...] > @@ -91,18 +97,33 @@ static const struct snd_soc_dapm_route audio_paths[] = { > { "DAC", NULL, "SYSCLK" }, > { "DAC Output", NULL, "DAC" }, > { "DAC Output", NULL, "VMID" }, > - { "ADC", NULL, "SYSCLK" }, > - { "DAC", NULL, "ADC_PWR" }, > - { "ADC", NULL, "ADC_PWR" }, > { "DAC1OUT", NULL, "DAC Output" }, > { "DAC2OUT", NULL, "DAC Output" }, > { "DAC3OUT", NULL, "DAC Output" }, > { "DAC4OUT", NULL, "DAC Output" }, > + { "SYSCLK", NULL, "PLL_PWR" }, > +}; > + > +static const struct snd_soc_dapm_route adc_audio_paths[] = { this should have the ad193x_ prefix as well. > + { "ADC", NULL, "SYSCLK" }, > + { "ADC", NULL, "ADC_PWR" }, > { "ADC", NULL, "ADC1IN" }, > { "ADC", NULL, "ADC2IN" }, > - { "SYSCLK", NULL, "PLL_PWR" }, > };