public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	amaury.denoyelle@gmail.com, abbotti@mev.co.uk
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code
Date: Tue, 29 Sep 2015 10:55:09 +0100	[thread overview]
Message-ID: <560A5FFD.9000405@osg.samsung.com> (raw)
In-Reply-To: <20150929012315.GB1252@kroah.com>

On 29/09/15 02:23, Greg KH wrote:
> On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote:
>> Remove the disabled code, for now, with #if 0.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>>
>> Hi,
>>
>> The code after the return is dead code. There is a comment saying it is
>> disabled for now, it would be good if the code is removed with #if 0 as
>> well.
> 
> The compiler doesn't add it anyway, so this is the same as what you just
> did, so I don't think it's needed.
> 
> thanks,
> 
> greg k-h
> 

Hi Greg,

I thought it would be easier to read if the code was explicitly marked as
dead/uncompiled.
You are correct though, it is probably not worth it.

Thanks for the review,
Luis

  reply	other threads:[~2015-09-29  9:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 20:54 [PATCH] staging: comedi: ni_tiocmd: remove unused code Luis de Bethencourt
2015-09-28 21:10 ` [PATCH] staging: comedi: cb_pcidas64: " Luis de Bethencourt
2015-09-29  1:23   ` Greg KH
2015-09-29  9:55     ` Luis de Bethencourt [this message]
2015-09-28 21:52 ` [PATCH] staging: rtl8712: remove dead code Luis de Bethencourt
2015-09-30  5:32   ` Joshua Clayton
2015-09-29  1:22 ` [PATCH] staging: comedi: ni_tiocmd: remove unused code Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560A5FFD.9000405@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=abbotti@mev.co.uk \
    --cc=amaury.denoyelle@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox