From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934198AbbI2JzL (ORCPT ); Tue, 29 Sep 2015 05:55:11 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39769 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933425AbbI2JzE (ORCPT ); Tue, 29 Sep 2015 05:55:04 -0400 Message-ID: <560A5FFD.9000405@osg.samsung.com> Date: Tue, 29 Sep 2015 10:55:09 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Greg KH CC: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, amaury.denoyelle@gmail.com, abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code References: <1443473685-3689-1-git-send-email-luisbg@osg.samsung.com> <1443474642-9965-1-git-send-email-luisbg@osg.samsung.com> <20150929012315.GB1252@kroah.com> In-Reply-To: <20150929012315.GB1252@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/15 02:23, Greg KH wrote: > On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote: >> Remove the disabled code, for now, with #if 0. >> >> Signed-off-by: Luis de Bethencourt >> --- >> >> Hi, >> >> The code after the return is dead code. There is a comment saying it is >> disabled for now, it would be good if the code is removed with #if 0 as >> well. > > The compiler doesn't add it anyway, so this is the same as what you just > did, so I don't think it's needed. > > thanks, > > greg k-h > Hi Greg, I thought it would be easier to read if the code was explicitly marked as dead/uncompiled. You are correct though, it is probably not worth it. Thanks for the review, Luis