From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965068AbbI2Nf4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 09:35:56 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:41496 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965003AbbI2Nfr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 09:35:47 -0400
X-AuditID: cbfec7f5-f794b6d000001495-04-560a93b1b41c
Message-id: <560A93B0.3070605@samsung.com>
Date: Tue, 29 Sep 2015 15:35:44 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: leds: inconsistent use of EXPORT_SYMBOL_* macros
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHLMWRmVeSWpSXmKPExsVy+t/xq7obJ3OFGWz7y25xedccNoutb9Yx
	Wjzqe8vuwOxxYsZvFo/Pm+QCmKK4bFJSczLLUov07RK4Mu7tuMxacJ2tYt4i3QbGo6xdjJwc
	EgImEh+uz2OEsMUkLtxbzwZiCwksZZSY+dati5ELyH7GKLH3zVqwBK+AlsTNy5eYQGwWAVWJ
	aZd/gMXZBAwlfr54DRYXFYiQ+HN6HytEvaDEj8n3WEBsEQEjic8vroDFmQWiJZoaJgMt5uAQ
	FrCUOHXQAiJsLbFy0jZGCFteYvOat8wTGPlmIZk0C0nZLCRlCxiZVzGKppYmFxQnpeca6RUn
	5haX5qXrJefnbmKEhNrXHYxLj1kdYhTgYFTi4TXo4wwTYk0sK67MPcQowcGsJMLL0MAVJsSb
	klhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbG0h1WbeIHfzxa
	W/dC97WF8K6+lZf6rk0/zHB2RVRZ96TkQ38f+L2UPF9qe2OF+dFW1yfM1254+k16L3zoyRaF
	/RWytlsfHDqzY+2cCUnckuctTwhf5Kn1Erp3d9OMMq6NBpMlZ8mqPvteHfT6ZKbBDNfCDu1T
	4le4Ci7lqs2yuWsx9eXDyI6tckosxRmJhlrMRcWJAFwtiFwxAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Linus,

In drivers/leds/led-core.c some symbols are exported with
EXPORT_SYMBOL and other with EXPORT_SYMBOL_GPL macros.

It seems that this mess wasn't introduced intentionally, but rather
carelessly, as in case of led_blink_set() and led_stop_software_blink()
functions, where the former, which enables blinking, is exported with
EXPORT_SYMBOL, and the latter, which disables blinking, with
EXPORT_SYMBOL_GPL.

It is also worth of noting that all symbols in drivers/led/led-class.c
are exported with EXPORT_SYMBOL_GPL, which implies that it is not
possible to register LED class device with non-GPL API, which in
turn rather eliminates non-GPL users of led-core API.

I'd like just confirm that in this case we are permitted to
switch to using EXPORT_SYMBOL_GPL consequently in the LED core.

-- 
Best Regards,
Jacek Anaszewski