From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756353AbbI2Nrm (ORCPT ); Tue, 29 Sep 2015 09:47:42 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35819 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378AbbI2Nre (ORCPT ); Tue, 29 Sep 2015 09:47:34 -0400 Message-ID: <560A9672.9@electrozaur.com> Date: Tue, 29 Sep 2015 16:47:30 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yaowei Bai , viro@zeniv.linux.org.uk, bhalevy@primarydata.com CC: osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443447836-5178-1-git-send-email-bywxiaobai@163.com> In-Reply-To: <1443447836-5178-1-git-send-email-bywxiaobai@163.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/28/2015 04:43 PM, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai ACK-by: Boaz Harrosh Please submit this through some General tree like the vfs or mm-tree Thanks Boaz > --- > fs/exofs/namei.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c > index 09a6bb1..994e078 100644 > --- a/fs/exofs/namei.c > +++ b/fs/exofs/namei.c > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, > struct inode *inode; > int err; > > - if (!new_valid_dev(rdev)) > - return -EINVAL; > - > inode = exofs_new_inode(dir, mode); > err = PTR_ERR(inode); > if (!IS_ERR(inode)) { >