From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935082AbbI2RJq (ORCPT ); Tue, 29 Sep 2015 13:09:46 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43811 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbbI2RJh (ORCPT ); Tue, 29 Sep 2015 13:09:37 -0400 Subject: Re: [PATCH] x86: include: asm: Fix build warning To: Borislav Petkov , Ksenija Stanojevic References: <1443543946-8624-1-git-send-email-ksenija.stanojevic@gmail.com> <20150929170651.GA3551@pd.tnic> Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org From: "H. Peter Anvin" Message-ID: <560AC5AA.7080203@zytor.com> Date: Tue, 29 Sep 2015 10:08:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150929170651.GA3551@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/2015 10:06 AM, Borislav Petkov wrote: > On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote: >> Fix build warnings: >> >> error: implicit declaration of function ‘olpc_board_at_least’ >> [-Werror=implicit-function-declaration] >> >> error: implicit declaration of function ‘olpc_board’ >> [-Werror=implicit-function-declaration] > > How exactly do you trigger that? > >> in files: >> drivers/power/olpc_battery.c >> drivers/input/mouse/hgpk.c >> drivers/staging/olpc_dcon/olpc_dcon.c >> arch/x86/platform/olpc/olpc.c >> sound/pci/cs5535audio/cs5535audio_olpc.c > > AFAICT, those should all depend on CONFIG_OLPC which defines those > functions... > It wouldn't be entirely impossible if OLPC has bitrotted. This is one of the many problems with nonstandard hardware. -hpa