From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935377AbbI2SNe (ORCPT ); Tue, 29 Sep 2015 14:13:34 -0400 Received: from emvm-gh1-uea09.nsa.gov ([63.239.67.10]:63139 "EHLO emvm-gh1-uea09.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935322AbbI2SNY (ORCPT ); Tue, 29 Sep 2015 14:13:24 -0400 X-TM-IMSS-Message-ID: <331e692a00004644@nsa.gov> Subject: Re: [PATCH 4/5] selinux: use kstrdup() in security_get_bools() To: Rasmus Villemoes , Paul Moore , Eric Paris , James Morris , "Serge E. Hallyn" References: <1443220459-11042-1-git-send-email-linux@rasmusvillemoes.dk> <1443220459-11042-5-git-send-email-linux@rasmusvillemoes.dk> Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov From: Stephen Smalley Organization: National Security Agency Message-ID: <560AD49E.8090405@tycho.nsa.gov> Date: Tue, 29 Sep 2015 14:12:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1443220459-11042-5-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/2015 06:34 PM, Rasmus Villemoes wrote: > This is much simpler. > > Signed-off-by: Rasmus Villemoes Acked-by: Stephen Smalley > --- > security/selinux/ss/services.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c > index 994c824a34c6..aa2bdcb20848 100644 > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -2609,18 +2609,12 @@ int security_get_bools(int *len, char ***names, int **values) > goto err; > > for (i = 0; i < *len; i++) { > - size_t name_len; > - > (*values)[i] = policydb.bool_val_to_struct[i]->state; > - name_len = strlen(sym_name(&policydb, SYM_BOOLS, i)) + 1; > > rc = -ENOMEM; > - (*names)[i] = kmalloc(sizeof(char) * name_len, GFP_ATOMIC); > + (*names)[i] = kstrdup(sym_name(&policydb, SYM_BOOLS, i), GFP_ATOMIC); > if (!(*names)[i]) > goto err; > - > - strncpy((*names)[i], sym_name(&policydb, SYM_BOOLS, i), name_len); > - (*names)[i][name_len - 1] = 0; > } > rc = 0; > out: >