From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965394AbbI2TUM (ORCPT ); Tue, 29 Sep 2015 15:20:12 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:40006 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965081AbbI2TUG (ORCPT ); Tue, 29 Sep 2015 15:20:06 -0400 X-Helo: d23dlp02.au.ibm.com X-MailFrom: raghavendra.kt@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Message-ID: <560AE486.2030500@linux.vnet.ibm.com> Date: Wed, 30 Sep 2015 00:50:38 +0530 From: Raghavendra K T Organization: IBM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Nishanth Aravamudan CC: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, anton@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, cl@linux.com, gkurz@linux.vnet.ibm.com, grant.likely@linaro.org, nikunj@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com Subject: Re: [PATCH RFC 3/5] powerpc:numa create 1:1 mappaing between chipid and nid References: <1443378553-2146-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <1443378553-2146-4-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <20150928173529.GF48470@linux.vnet.ibm.com> In-Reply-To: <20150928173529.GF48470@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15092919-0013-0000-0000-000001F731E8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/28/2015 11:05 PM, Nishanth Aravamudan wrote: > On 27.09.2015 [23:59:11 +0530], Raghavendra K T wrote: >> Once we have made the distinction between nid and chipid >> create a 1:1 mapping between them. This makes compacting the >> nids easy later. >> >> No functionality change. >> >> Signed-off-by: Raghavendra K T >> --- >> arch/powerpc/mm/numa.c | 36 +++++++++++++++++++++++++++++------- >> 1 file changed, 29 insertions(+), 7 deletions(-) >> >> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c >> index f84ed2f..dd2073b 100644 >> --- a/arch/powerpc/mm/numa.c >> +++ b/arch/powerpc/mm/numa.c >> @@ -264,6 +264,17 @@ out: >> return chipid; >> } >> >> + >> + /* Return the nid from associativity */ >> +static int associativity_to_nid(const __be32 *associativity) >> +{ >> + int nid; >> + >> + nid = associativity_to_chipid(associativity); >> + return nid; >> +} > > This is ultimately confusing. You are assigning the semantic return > value of a chipid to a nid -- is it a nid or a chipid? Shouldn't the > variable naming be consistent? > :( yes. will come up with some consistent naming.