From: Stephen Smalley <sds@tycho.nsa.gov>
To: Geliang Tang <geliangtang@163.com>,
Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/2] selinux: ioctl_has_perm should be static
Date: Tue, 29 Sep 2015 16:28:29 -0400 [thread overview]
Message-ID: <560AF46D.2040307@tycho.nsa.gov> (raw)
In-Reply-To: <ff802942c34154cceee8ab2256d8c5ce6a665d21.1443366384.git.geliangtang@163.com>
On 09/27/2015 11:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
>
next prev parent reply other threads:[~2015-09-29 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
2015-09-27 15:10 ` [PATCH 2/2] smack: smk_ipv6_port_list " Geliang Tang
2015-10-09 22:19 ` Casey Schaufler
2015-09-28 15:22 ` [PATCH 1/2] selinux: ioctl_has_perm " Jeffrey Vander Stoep
2015-09-29 20:28 ` Stephen Smalley [this message]
2015-09-30 17:11 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AF46D.2040307@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=eparis@parisplace.org \
--cc=geliangtang@163.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox