From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbbI2U3N (ORCPT ); Tue, 29 Sep 2015 16:29:13 -0400 Received: from emvm-gh1-uea08.nsa.gov ([63.239.67.9]:56857 "EHLO emvm-gh1-uea08.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbbI2U3J (ORCPT ); Tue, 29 Sep 2015 16:29:09 -0400 X-TM-IMSS-Message-ID: <7bd25cd900005a91@nsa.gov> Subject: Re: [PATCH 1/2] selinux: ioctl_has_perm should be static To: Geliang Tang , Paul Moore , Eric Paris , James Morris , "Serge E. Hallyn" References: Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov From: Stephen Smalley Organization: National Security Agency Message-ID: <560AF46D.2040307@tycho.nsa.gov> Date: Tue, 29 Sep 2015 16:28:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/27/2015 11:10 AM, Geliang Tang wrote: > Fixes the following sparse warning: > > security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was > not declared. Should it be static? > > Signed-off-by: Geliang Tang Acked-by: Stephen Smalley > --- > security/selinux/hooks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 84d21f9..5265c74 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file) > * Check whether a task has the ioctl permission and cmd > * operation to an inode. > */ > -int ioctl_has_perm(const struct cred *cred, struct file *file, > +static int ioctl_has_perm(const struct cred *cred, struct file *file, > u32 requested, u16 cmd) > { > struct common_audit_data ad; >