From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbbI2VNS (ORCPT ); Tue, 29 Sep 2015 17:13:18 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:26528 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbbI2VNI (ORCPT ); Tue, 29 Sep 2015 17:13:08 -0400 Subject: Re: Trivial clocksource driver To: Mans Rullgard Cc: Thomas Gleixner , LKML , Daniel Lezcano References: <560ABB95.8000404@free.fr> <560AEB32.50006@free.fr> From: Mason Message-ID: <560AFED6.3020400@free.fr> Date: Tue, 29 Sep 2015 23:12:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mans, On 29/09/2015 22:18, Måns Rullgård wrote: > Mason writes: > >> On 29/09/2015 20:32, Thomas Gleixner wrote: >> >>> On Tue, 29 Sep 2015, Mason wrote: >>> >>>> I am trying to submit a new ARM port, and Arnd pointed out that the >>>> clocksource code could not live in arch/arm/$PLATFORM, but had to >>>> move to drivers/clocksource (and it had to support DT). >>>> >>>> Did I understand correctly? Is this the right place to submit code >>>> as provided below? >>> >>> Yes, drivers/clocksource is the right place. You just need to submit a >>> formal patch, which includes a proper subject line, changelog, plus >>> the necessary Makefile and Kconfig modifications. >> >> OK, I'll send a formal patch tomorrow. >> There are no Kconfig modifications, is that OK? > > Why don't you use my driver? It's even simpler, and it works just fine > on the 87xx chip. > > https://github.com/mansr/linux-tangox/blob/master/drivers/clocksource/clksrc-tangox.c As you know, I am using two of your complex drivers, namely ethernet and interrupt controller (which would have taken me several weeks to write). I will be submitting them upstream shortly, is that OK with you? I'm not using this particular driver of yours because I had already written the code, and porting it to DT was a good learning process. This is probably my only opportunity to actually write any kind of code for this port. Regards.