From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbbI3Aar (ORCPT ); Tue, 29 Sep 2015 20:30:47 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8349 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079AbbI3Aao (ORCPT ); Tue, 29 Sep 2015 20:30:44 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-33-560b2d30e434 Subject: Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1443527855-434-1-git-send-email-javier@osg.samsung.com> Cc: Mauro Carvalho Chehab , Doug Anderson , Olof Johansson , Russell King , Kukjin Kim , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <560B2D29.5060707@samsung.com> Date: Wed, 30 Sep 2015 09:30:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1443527855-434-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t/xa7oGutxhBjdOaVjMP3KO1eLssoNs Fv1vFrJanHu1ktHizds1TBavXxha9D9+zWyx6fE1VovLu+awWcw4v4/J4vZlXoul1y8yWax+ VmFx6vpnNosJ09eyWLTuPcLuIOCxZt4aRo+W5h42j9kNF1k8Lvf1MnmsXP6FzWPTqk42j81L 6j2unGhi9djSf5fdo2/LKkaPz5vkArijuGxSUnMyy1KL9O0SuDLOd31lKXgnUNHWP429gfEa bxcjJ4eEgInEwq97GSFsMYkL99azdTFycQgJLGWUeLDtPZTzhVHi9ak1YFXCAg4Sd6Y/Ygex RQRCJf5dvA0U5wAqcpG49oIRpJ5Z4C2zxLsNO1hAatgEjCU2L1/CBmLzCmhJTG3fxgxiswio Slxa9wCsRlQgQuLU2bdQNYISPybfA4tzCrhKLFh3jQ1kPrOAnsT9i1ogYWYBeYnNa94yT2AU mIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihETclx2Mi49ZHWIU4GBU 4uF9IcAdJsSaWFZcmXuIUYKDWUmE9702UIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE 0hNLUrNTUwtSi2CyTBycUg2MYrtmrD5mFKL0Y1NtSEiMexVPxw9uAc96vWxBWfVTMxXrGd3e 1HD8i3l5tfN8hfD0oh03d+2b3lUWvWTqhS2KLc2atW6yr2SqQ4yzb65vN35cYpi3w56tbOu2 uW++nV+mJxson/zg9QHWsk3WZ6Z6l8q4+S3kiQ/e7XjU2d9mecfUH+/LrpkosRRnJBpqMRcV JwIA6DAcy7QCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.09.2015 20:57, Javier Martinez Canillas wrote: > There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: > Rev4 and Rev5. The only difference between these 2 revisions is the codec, > Rev4 has a max98095 codec while Rev5 has a max98090. > > Mainline only supports Rev4 so this patch moves the common device nodes to > a DTSI file and adds a DTS for the Exynos5250 Snow Rev5. > > The Snow Rev5 DTS is based on the DTS found in the ChromiumOS 3.8 tree. > > Signed-off-by: Javier Martinez Canillas > > --- > > The DTS in the vendor ChromeOS tree are called exynos5250-snow-rev{4,5}.dtb > but I decided to leave Rev4 as exynos5250-snow.dtb to avoid breaking u-boot > that has CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" in snow_defconfig. > > Also, ChromiumOS Rev4 DTS has "google,snow-rev4" in its compatible string > but was not added in mainline since Rev4 firmware fallbacks to "google,snow" > and Rev5 searches for "google,snow-rev5". That way the compatible string > could be consistent with the DTS naming and still be able to pack both Rev4 > and Rev5 FDT in the same FIT image and let the firmware pick the correct FDT. > > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684 ++++++++++++++++++++++++++ > arch/arm/boot/dts/exynos5250-snow-rev5.dts | 47 ++ > arch/arm/boot/dts/exynos5250-snow.dts | 666 +------------------------ > 4 files changed, 733 insertions(+), 665 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos5250-snow-common.dtsi > create mode 100644 arch/arm/boot/dts/exynos5250-snow-rev5.dts Now the exynos5250-snow.dts means in fact Rev4... but there is no information in DTS about it. I think adding compatible "google,snow-rev4" makes sense: 1. For informational purposes (this could be also handled with a comment). 2. Later one could decide to switch the default meaning of "google,snow" to Rev5 and the real compatible (rev4) will be there already. Could you add the new compatible and fix patch issues pointed by Doug? Best regards, Krzysztof