From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbbI3BOm (ORCPT ); Tue, 29 Sep 2015 21:14:42 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61337 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbbI3BOi (ORCPT ); Tue, 29 Sep 2015 21:14:38 -0400 X-AuditID: cbfec7f5-f794b6d000001495-8b-560b377b4381 Subject: Re: [PATCH RESEND] mach:-s3c64xx:Cause kernel oops with WARN_ON if calls for setting up gpio fail in s3c64xx_i2s_cfg_gpio To: Nicholas Krause , kgene@kernel.org References: <1442537674-26953-1-git-send-email-xerofoify@gmail.com> Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <560B3771.2090300@samsung.com> Date: Wed, 30 Sep 2015 10:14:25 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1442537674-26953-1-git-send-email-xerofoify@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xK7rV5txhBs9eMFm8fmFo0f/4NbPF psfXWC0u75rDZjHj/D4mi9uXeS1+TZF1YPdoae5h89g56y67x6ZVnWwem5fUe/RtWcXo8XmT XABbFJdNSmpOZllqkb5dAlfG4yevmAr+C1RsWLaCpYGxh6+LkYNDQsBEYtfH8C5GTiBTTOLC vfVsXYxcHEICSxklmp6+ZgRJCAl8YZQ4+a0GJCEs0MIoMevXQlaQhIiAtcT8+zehipwlJjT1 MIMUMQs0M0p0X7zBDpJgEzCW2Lx8CRvECjmJ3u5JLCA2r4CWxIXFy8BsFgFVicPzb4LZogIR EqfOvmWDqBGU+DH5HlicU8BFYl/zPEaQq5kF9CTuX9QCCTMLyEtsXvOWeQKj4CwkHbMQqmYh qVrAyLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cTIyT4v+5gXHrM6hCjAAejEg/vCwHuMCHW xLLiytxDjBIczEoivO+1gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQ WgSTZeLglGpgFPQ/Vj7fT+dw1wFnpTlz2XvilLiW963aJdZ1OazNLaSuMlme2S/z8/tmoSmX lTsv8GzkeHqTMdR0xsafBX/yjqbZPHL6vujAYh+bWnaBGQFm9/5IbPuYPNnf+mS10l7TD9sL zyZNY7c/3uRtEKe+jVVhDdPdqysy49c9e+M10WOOV9SSWjtvJZbijERDLeai4kQAX7kVHnoC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.09.2015 09:54, Nicholas Krause wrote: > This fixes the function s3c64xx_i2c_cfg_gpio The problem is not described and you did not provide a fix so the description is highly inaccurate and misleading. > to cause a kernel oopes Warn causes oops? > if the call to either s3c_gpio_cfgpin_range or s3c_gpio_cfgpin fail > as we cannot continue to run "cannot continue to run" means BUG_ON? > on a board using this gpio setup if > the configuration for the board fails when the gpio configuration > of the board is being reconfigured in the function in > s3c64xx_i2s_cfg_gpio. Please rephrase. You essentially said "Configuration fails when configuration is being reconfigured". Too many configurations... Fix the subject as well. Best regards, Krzysztof > > Signed-off-by: Nicholas Krause > --- > arch/arm/mach-s3c64xx/dev-audio.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/dev-audio.c b/arch/arm/mach-s3c64xx/dev-audio.c > index ff780a8..5e7538b 100644 > --- a/arch/arm/mach-s3c64xx/dev-audio.c > +++ b/arch/arm/mach-s3c64xx/dev-audio.c > @@ -36,10 +36,10 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev) > base = S3C64XX_GPE(0); > break; > case 2: > - s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5)); > - s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5)); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5))); > + WARN_ON(s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));) > return 0; > default: > printk(KERN_DEBUG "Invalid I2S Controller number: %d\n", > @@ -47,7 +47,7 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev) > return -EINVAL; > } > > - s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3)); > + WARN_ON(s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3))); > > return 0; > } >