From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbI3FRt (ORCPT ); Wed, 30 Sep 2015 01:17:49 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:11125 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbI3FRo (ORCPT ); Wed, 30 Sep 2015 01:17:44 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ae-560b70754451 Subject: Re: [PATCH v5 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe@perches.com, Rob Herring References: <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <1442906963-2883-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <560B7068.2000008@samsung.com> Date: Wed, 30 Sep 2015 14:17:28 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1442906963-2883-1-git-send-email-ykk@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRiGe/cd9nlYva6sl/oRfFA/hCxL4SEqJEjeP4F0sANGfbqPaTmT rUkalKV20GwrC3VK62weWuEBD1iWmJLhylZamU4ScepUMFuRqDkt6t/93Nf9PPefR2DUedxK IT7xhKxPlBJE3pd9PdP6YZ0xyS9qgzVXhM82Owc59lcKeOK+zYDpzScE1uY5r/3BCx7O5ls5 eP99nIeGD70KMLlvczBRlqmE2a8jHNiHSxBcc5pZeDhZoIRCZz8Lrt4OFkZcIWDqH2Hg7cBl HtrPuZVQ0d/JgaO+iIeJvlkG8t88U0C3QwW1158rwJz3iIXMp81K+OHx8NDzpB1Bfu4QD91T i8GelqsMF2n5zXJEM9Iv87QwrYOljis5Cjo92MXSOkuPkpYUT/K0ovQST2s8fRx1ZrcqaOW9 MzQnfYynk6WdDJ22NLL0SlUpojWdN5lI9UHfLRo5IT5Z1q/fdsQ3buzlEJ/UpTr5w+zk01C2 XxbyEQgOJZ7HbcyCXk7e9j7ms5CvoMb3EbEUfWMXhklEMspnFN7UUqwhxXXnGS9YhisZcne0 YR6ocQqZzq+b32Dwa44MNk9wXsDjTaSy+B7v1SocRMarrfN9LF5DCp2meR2I95O29tE/mQDy M7eX9WofvJ1c+OKeKxDmjgYTZ0eQ12bwalJZPsqYEbb8t2H5l7L8l7qFmFIUKBtjkwwxWt3G YIOkMxgTtcGxx3UVaOFdvtei+y2bmxAWkOivcmG/KDUnJRtSdE2ICIy4TDUAc5ZKI6Wkyvrj h/XGBNnQhFYJrLhCVVA/vkeNtdIJ+ZgsJ8n6v1Qh+KxMQ46I6+OxEdLz1Oiwo+niWPTd0Bua qvDPKY47hS1r7OYdthHRvXZXtG1ntXtK2rnEtenQAa0rbMfVtl+nSZPmI76oy7TN6nSN/mEB aiahtSyxxBZt1S464gg5VRRRsDWg2GnI2esfpaSRY8bhO3ErPKZ3fostu2NCWwKr9qU3NIis IU4KCWL0Buk3HsX75CoDAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.09.2015 16:29, Yakir Yang wrote: > Split the dp core driver from exynos directory to bridge directory, > and rename the core driver to analogix_dp_*, rename the platform > code to exynos_dp. > > Beside the new analogix_dp driver would export four hooks. > "analogix_dp_bind()" and "analogix_dp_unbind()" > "analogix_dp_detect()" and "analogix_dp_get_modes()" > > The bind/unbind symbols is used for analogix platform driver to connect > with analogix_dp core driver. And the detect/get_modes is used for analogix > platform driver to init the connector. > > They reason why connector need register in helper driver is rockchip drm > haven't implement the atomic API, but Exynos drm have implement it, so > there would need two different connector helper functions, that's why we > leave the connector register in helper driver. > > Signed-off-by: Yakir Yang > --- > Changes in v5: > - Correct the check condition of gpio_is_valid when driver try to get > the "hpd-gpios" DT propery. (Heiko) > - Move the platform attach callback in the front of core driver bridge > attch function. Cause once platform failed at attach, core driver should > still failed, so no need to init connector before platform attached (Krzysztof) > - Keep code style no changes with the previous exynos_dp_code.c in this > patch, and update commit message about the new export symbol (Krzysztof) > - Gather the device type patch (v4 11/16) into this one. (Krzysztof) > - leave out the connector registration to analogix platform driver. (Thierry) Thanks for fixing this, looks much better. I don't feel comfortable enough to provide a review tag but it looks good to me. Best regards, Krzysztof