From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbbI3Gvq (ORCPT ); Wed, 30 Sep 2015 02:51:46 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:39595 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753746AbbI3Gvo (ORCPT ); Wed, 30 Sep 2015 02:51:44 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 172.245.202.96 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <30f404989eff0f3d8919cb2815fe6348> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 5 Message-ID: <560B85A4.2040907@rock-chips.com> Date: Wed, 30 Sep 2015 14:48:04 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe@perches.com, Rob Herring CC: David Airlie , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory References: <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <1442906963-2883-1-git-send-email-ykk@rock-chips.com> <560B7068.2000008@samsung.com> In-Reply-To: <560B7068.2000008@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 09/30/2015 01:17 PM, Krzysztof Kozlowski wrote: > On 22.09.2015 16:29, Yakir Yang wrote: >> Split the dp core driver from exynos directory to bridge directory, >> and rename the core driver to analogix_dp_*, rename the platform >> code to exynos_dp. >> >> Beside the new analogix_dp driver would export four hooks. >> "analogix_dp_bind()" and "analogix_dp_unbind()" >> "analogix_dp_detect()" and "analogix_dp_get_modes()" >> >> The bind/unbind symbols is used for analogix platform driver to connect >> with analogix_dp core driver. And the detect/get_modes is used for analogix >> platform driver to init the connector. >> >> They reason why connector need register in helper driver is rockchip drm >> haven't implement the atomic API, but Exynos drm have implement it, so >> there would need two different connector helper functions, that's why we >> leave the connector register in helper driver. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v5: >> - Correct the check condition of gpio_is_valid when driver try to get >> the "hpd-gpios" DT propery. (Heiko) >> - Move the platform attach callback in the front of core driver bridge >> attch function. Cause once platform failed at attach, core driver should >> still failed, so no need to init connector before platform attached (Krzysztof) >> - Keep code style no changes with the previous exynos_dp_code.c in this >> patch, and update commit message about the new export symbol (Krzysztof) >> - Gather the device type patch (v4 11/16) into this one. (Krzysztof) >> - leave out the connector registration to analogix platform driver. (Thierry) > Thanks for fixing this, looks much better. > > I don't feel comfortable enough to provide a review tag but it looks > good to me. Thanks ;) - Yakir > Best regards, > Krzysztof > > > >