From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbbI3HCv (ORCPT ); Wed, 30 Sep 2015 03:02:51 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:15347 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753746AbbI3HCs (ORCPT ); Wed, 30 Sep 2015 03:02:48 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-b4-560b8915580f Subject: Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support To: Kukjin Kim References: <1443527855-434-1-git-send-email-javier@osg.samsung.com> <560B2D29.5060707@samsung.com> <560B8818.8020002@kernel.org> Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Doug Anderson , Olof Johansson , Russell King , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <560B890C.3060200@samsung.com> Date: Wed, 30 Sep 2015 16:02:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <560B8818.8020002@kernel.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xa7qindxhBudOs1rMP3KO1eLssoNs Fv1vFrJanHu1ktHizds1TBavXxha9D9+zWyx6fE1VovLu+awWcw4v4/J4vZlXoul1y8yWax+ VmFx6vpnNosJ09eyWLTuPcLuIOCxZt4aRo+W5h42j9kNF1k8Lvf1MnmsXP6FzWPTqk42j81L 6j2unGhi9djSf5fdo2/LKkaPz5vkArijuGxSUnMyy1KL9O0SuDIubl/DXPBauOLppB72BsY5 Al2MnBwSAiYSj6ZfY4awxSQu3FvP1sXIxSEksJRR4ursX0wQzhdGiX+vdzOCVAkLOEjcmf6I vYuRg0NEQFFi8wIFiJpmRomWP3PBupkFFrJILDz0DayBTcBYYvPyJWwgNq+AlsSdf2tZQWwW AVWJxadugtWICkRInDr7FqpGUOLH5HssIDYnUH3P+20sIMuYBfQk7l/UAgkzC8hLbF7zlnkC o8AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyMk5r7sYFx8zOoQowAH oxIP7wsB7jAh1sSy4srcQ4wSHMxKIrxPLYBCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefueh8i JJCeWJKanZpakFoEk2Xi4JRqYGSRLK//4KBY8lHE6Of0Jase+ez9XPdu974HPeu0TO47yjoc nrtVaPMpQRmh7Rs7cvj2M60/ur7T6i/PpMmshewWC803q8RzLW2z6Z/dsX7rr5OzfWfPmqb4 00X3bSZnxdeW0hmPTLmZJu8/vuNQuNSUzAf8FncqJaPSDxrNcPT9Zie63SuK644SS3FGoqEW c1FxIgBg9593tQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.09.2015 15:58, Kukjin Kim wrote: > On 09/30/15 09:30, Krzysztof Kozlowski wrote: >> On 29.09.2015 20:57, Javier Martinez Canillas wrote: >>> There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: >>> Rev4 and Rev5. The only difference between these 2 revisions is the codec, >>> Rev4 has a max98095 codec while Rev5 has a max98090. >>> >>> Mainline only supports Rev4 so this patch moves the common device nodes to >>> a DTSI file and adds a DTS for the Exynos5250 Snow Rev5. >>> >>> The Snow Rev5 DTS is based on the DTS found in the ChromiumOS 3.8 tree. >>> >>> Signed-off-by: Javier Martinez Canillas >>> >>> --- >>> >>> The DTS in the vendor ChromeOS tree are called exynos5250-snow-rev{4,5}.dtb >>> but I decided to leave Rev4 as exynos5250-snow.dtb to avoid breaking u-boot >>> that has CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" in snow_defconfig. >>> >>> Also, ChromiumOS Rev4 DTS has "google,snow-rev4" in its compatible string >>> but was not added in mainline since Rev4 firmware fallbacks to "google,snow" >>> and Rev5 searches for "google,snow-rev5". That way the compatible string >>> could be consistent with the DTS naming and still be able to pack both Rev4 >>> and Rev5 FDT in the same FIT image and let the firmware pick the correct FDT. >>> >>> arch/arm/boot/dts/Makefile | 1 + >>> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684 ++++++++++++++++++++++++++ >>> arch/arm/boot/dts/exynos5250-snow-rev5.dts | 47 ++ >>> arch/arm/boot/dts/exynos5250-snow.dts | 666 +------------------------ >>> 4 files changed, 733 insertions(+), 665 deletions(-) >>> create mode 100644 arch/arm/boot/dts/exynos5250-snow-common.dtsi >>> create mode 100644 arch/arm/boot/dts/exynos5250-snow-rev5.dts >> >> Now the exynos5250-snow.dts means in fact Rev4... but there is no >> information in DTS about it. I think adding compatible >> "google,snow-rev4" makes sense: >> 1. For informational purposes (this could be also handled with a comment). >> 2. Later one could decide to switch the default meaning of "google,snow" >> to Rev5 and the real compatible (rev4) will be there already. >> >> Could you add the new compatible and fix patch issues pointed by Doug? >> > Documenting for the compatibles would be required even I already applied > its updated patch... What do you mean by "documenting compatibles"? These are board compatibles, they are not documented... Best regards, Krzysztof