From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754382AbbI3HZh (ORCPT ); Wed, 30 Sep 2015 03:25:37 -0400 Received: from lists.s-osg.org ([54.187.51.154]:40055 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbbI3HZf (ORCPT ); Wed, 30 Sep 2015 03:25:35 -0400 Subject: Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support To: Krzysztof Kozlowski , Kukjin Kim References: <1443527855-434-1-git-send-email-javier@osg.samsung.com> <560B2D29.5060707@samsung.com> <560B8818.8020002@kernel.org> <560B890C.3060200@samsung.com> <560B8A0F.8090709@osg.samsung.com> <560B8A8A.5050506@samsung.com> Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Doug Anderson , Olof Johansson , Russell King , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <560B8E67.1080202@osg.samsung.com> Date: Wed, 30 Sep 2015 09:25:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <560B8A8A.5050506@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 09/30/2015 09:08 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 16:06, Javier Martinez Canillas wrote: >> Hello, >> >> On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >>> On 30.09.2015 15:58, Kukjin Kim wrote: >> >> [snip] >> >>>>> >>>>> Could you add the new compatible and fix patch issues pointed by Doug? >>>>> >>>> Documenting for the compatibles would be required even I already applied >>>> its updated patch... >>> >> >> Kukjin, I agree that they should be documented but I thought it would >> be a separate patch since currently we don't document any board. >> >>> What do you mean by "documenting compatibles"? These are board >>> compatibles, they are not documented... >>> >> >> Krzysztof, I've on my TODO list to add a file describing all Exynos >> platforms and DT bindings, something like what other SoC do, i.e: >> >> Documentation/devicetree/bindings/arm/omap/omap.txt >> Documentation/devicetree/bindings/arm/rockchip.txt > > Right, that's a good idea. However lack of it does not affect current > work because compatibles for Exynos board are not documented at all. > Agreed. That's why I didn't add it, even when checkpatch.pl complains: WARNING: DT compatible string "google,snow-rev5" appears un-documented -- check ./Documentation/devicetree/bindings/ > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America