From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755842AbbI3J4c (ORCPT ); Wed, 30 Sep 2015 05:56:32 -0400 Received: from lists.s-osg.org ([54.187.51.154]:40088 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754921AbbI3J43 (ORCPT ); Wed, 30 Sep 2015 05:56:29 -0400 Message-ID: <560BB1CA.8090300@osg.samsung.com> Date: Wed, 30 Sep 2015 10:56:26 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: jikos@kernel.com, linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect() References: <1443606749-6028-1-git-send-email-luisbg@osg.samsung.com> In-Reply-To: <1443606749-6028-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/15 10:52, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. > > Also, the smatch tool complains with the following warning: > hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt > --- > drivers/hid/usbhid/hiddev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c > index 2f1ddca..c5290ff 100644 > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -894,7 +894,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force) > } > > if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL))) > - return -1; > + return -ENOMEM; > > init_waitqueue_head(&hiddev->wait); > INIT_LIST_HEAD(&hiddev->list); > Hello, I got an "Undelivered Mail Returned to Sender" from Jiri Kosina's jikos@kernel.com email address. This email is listed multiple times in the MAINTAINERS file, does he have a new address to update this file? Thanks, Luis