From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756411AbbI3KRp (ORCPT ); Wed, 30 Sep 2015 06:17:45 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35678 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754682AbbI3KRm (ORCPT ); Wed, 30 Sep 2015 06:17:42 -0400 Subject: Re: [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage To: Daniel Lezcano , tglx@linutronix.de References: <560BB452.1020000@linaro.org> <1443607710-10415-1-git-send-email-daniel.lezcano@linaro.org> Cc: "open list:ARM/Rockchip SoC..." , linux@arm.linux.org.uk, Heiko Stuebner , "moderated list:ARM/Rockchip SoC..." , "open list:CLOCKSOURCE, CLOC..." From: Caesar Wang Message-ID: <560BB6BD.4080509@gmail.com> Date: Wed, 30 Sep 2015 18:17:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443607710-10415-1-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015年09月30日 18:08, Daniel Lezcano 写道: > The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case > of failure. Unfortunately, the NO_IRQ is not consistent across the different > architectures and we must not rely on it. > > NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case > of an error. Hence, the latter won't be detected and will lead to a crash. > > Fix this by just checking 'irq' is different from zero. > > Signed-off-by: Daniel Lezcano As Per- discuss, you can free add my test tag. Tested-by: Caesar Wang > --- > drivers/clocksource/rockchip_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c > index bb2c2b0..d3c1742 100644 > --- a/drivers/clocksource/rockchip_timer.c > +++ b/drivers/clocksource/rockchip_timer.c > @@ -148,7 +148,7 @@ static void __init rk_timer_init(struct device_node *np) > bc_timer.freq = clk_get_rate(timer_clk); > > irq = irq_of_parse_and_map(np, 0); > - if (irq == NO_IRQ) { > + if (!irq) { > pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME); > return; > } -- Thanks, Caesar