From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756668AbbI3K0j (ORCPT ); Wed, 30 Sep 2015 06:26:39 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35030 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754837AbbI3K0f (ORCPT ); Wed, 30 Sep 2015 06:26:35 -0400 Message-ID: <560BB8D7.1050703@electrozaur.com> Date: Wed, 30 Sep 2015 13:26:31 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yaowei Bai , Al Viro , Andrew Morton CC: osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443447836-5178-1-git-send-email-bywxiaobai@163.com> <560A9672.9@electrozaur.com> <20150929154631.GA6489@bbox> In-Reply-To: <20150929154631.GA6489@bbox> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/2015 06:46 PM, Yaowei Bai wrote: > On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote: >> On 09/28/2015 04:43 PM, Yaowei Bai wrote: >>> As new_valid_dev always returns 1, so !new_valid_dev check is not >>> needed, remove it. >>> >>> Signed-off-by: Yaowei Bai >> >> ACK-by: Boaz Harrosh > > Thanks. > >> >> Please submit this through some General tree like the vfs or mm-tree > > This's my first fs-specific patch, so i think you mean i should cc vfs > or mm-tree? > Yes you should ask Al (or Morton) to take the all patchset through their tree. Then once all users of new_valid_dev() are gone it can be removed in the one tree. Thanks Boaz >> >> Thanks >> Boaz >> >>> --- >>> fs/exofs/namei.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c >>> index 09a6bb1..994e078 100644 >>> --- a/fs/exofs/namei.c >>> +++ b/fs/exofs/namei.c >>> @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, >>> struct inode *inode; >>> int err; >>> >>> - if (!new_valid_dev(rdev)) >>> - return -EINVAL; >>> - >>> inode = exofs_new_inode(dir, mode); >>> err = PTR_ERR(inode); >>> if (!IS_ERR(inode)) { >>> > >