From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755594AbbI3Kvu (ORCPT ); Wed, 30 Sep 2015 06:51:50 -0400 Received: from smtp.citrix.com ([66.165.176.89]:25773 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754619AbbI3Kvs (ORCPT ); Wed, 30 Sep 2015 06:51:48 -0400 X-IronPort-AV: E=Sophos;i="5.17,611,1437436800"; d="scan'208";a="303323533" Message-ID: <560BBE73.3070402@citrix.com> Date: Wed, 30 Sep 2015 11:50:27 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: CC: , , , , "Julien Grall" , David Vrabel , Konrad Rzeszutek Wilk , Boris Ostrovsky Subject: Re: [PATCH v5 05/22] xen/grant: Add helper gnttab_page_grant_foreign_access_ref_one References: <1443609937-25278-1-git-send-email-julien.grall@citrix.com> <1443609937-25278-6-git-send-email-julien.grall@citrix.com> In-Reply-To: <1443609937-25278-6-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/15 11:45, Julien Grall wrote: > Many PV drivers contain the idiom: > > pfn = page_to_gfn(...) /* Or similar */ > gnttab_grant_foreign_access_ref > > Replace it by a new helper. Note that when Linux is using a different > page granularity than Xen, the helper only gives access to the first 4KB > grant. > > This is useful where drivers are allocating a full Linux page for each > grant. > > Also include xen/interface/grant_table.h rather than xen/grant_table.h in > asm/page.h for x86 to fix a compilation issue [1]. Only the former is > useful in order to get the structure definition. > > [1] Interdependency between asm/page.h and xen/grant_table.h which result > to page_mfn not being defined when necessary. > > Signed-off-by: Julien Grall Hmmm... this should be julien.grall@citrix.com. Still mixing up with my old address. I've fixed it in the branch associated to this series. Regards, -- Julien Grall