public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal@dev.mellanox.co.il>
To: ira.weiny@intel.com
Cc: dledford@redhat.com, xerofoify@gmail.com,
	linux-rdma@vger.kernel.org, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, jgunthorpe@obsidianresearch.com,
	yun.wang@profitbricks.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] IB/mad: remove obsolete snoop interface
Date: Wed, 30 Sep 2015 08:54:47 -0400	[thread overview]
Message-ID: <560BDB97.8010908@dev.mellanox.co.il> (raw)
In-Reply-To: <1443592864-32019-1-git-send-email-ira.weiny@intel.com>

On 9/30/2015 2:01 AM, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> This interface has no current users and is obsolete.

There are no in tree users of this but there is Sean's madeye tool
(which is out of tree). This is still a useful debug tool for MADs.

> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
> 
> This has undergone a medium level of testing.  I have run it against
> mlx4, qib, and OPA hardware and it does not seem to cause any regressions.
> 
>  drivers/infiniband/core/mad.c      | 226 +------------------------------------
>  drivers/infiniband/core/mad_priv.h |  13 ---
>  2 files changed, 5 insertions(+), 234 deletions(-)

There are also snoop changes needed in include/rdma/ib_mad.h.

Is it correct to assume that OPA_CAP_MASK3_IsSnoopSupported in
opa_port_info.h is not related to this ?

-- Hal

  reply	other threads:[~2015-09-30 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  6:01 [PATCH RFC] IB/mad: remove obsolete snoop interface ira.weiny
2015-09-30 12:54 ` Hal Rosenstock [this message]
2015-09-30 16:32   ` Weiny, Ira
2015-09-30 19:03     ` Hal Rosenstock
2015-09-30 19:31       ` Weiny, Ira
2015-10-04 21:00 ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560BDB97.8010908@dev.mellanox.co.il \
    --to=hal@dev.mellanox.co.il \
    --cc=dledford@redhat.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=xerofoify@gmail.com \
    --cc=yun.wang@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox