From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933409AbbI3Myy (ORCPT ); Wed, 30 Sep 2015 08:54:54 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36199 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932247AbbI3Myw (ORCPT ); Wed, 30 Sep 2015 08:54:52 -0400 Message-ID: <560BDB97.8010908@dev.mellanox.co.il> Date: Wed, 30 Sep 2015 08:54:47 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: ira.weiny@intel.com CC: dledford@redhat.com, xerofoify@gmail.com, linux-rdma@vger.kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, jgunthorpe@obsidianresearch.com, yun.wang@profitbricks.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] IB/mad: remove obsolete snoop interface References: <1443592864-32019-1-git-send-email-ira.weiny@intel.com> In-Reply-To: <1443592864-32019-1-git-send-email-ira.weiny@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2015 2:01 AM, ira.weiny@intel.com wrote: > From: Ira Weiny > > This interface has no current users and is obsolete. There are no in tree users of this but there is Sean's madeye tool (which is out of tree). This is still a useful debug tool for MADs. > Signed-off-by: Ira Weiny > --- > > This has undergone a medium level of testing. I have run it against > mlx4, qib, and OPA hardware and it does not seem to cause any regressions. > > drivers/infiniband/core/mad.c | 226 +------------------------------------ > drivers/infiniband/core/mad_priv.h | 13 --- > 2 files changed, 5 insertions(+), 234 deletions(-) There are also snoop changes needed in include/rdma/ib_mad.h. Is it correct to assume that OPA_CAP_MASK3_IsSnoopSupported in opa_port_info.h is not related to this ? -- Hal