From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbbI3OHH (ORCPT ); Wed, 30 Sep 2015 10:07:07 -0400 Received: from mail-bl2on0077.outbound.protection.outlook.com ([65.55.169.77]:10496 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752578AbbI3OG7 (ORCPT ); Wed, 30 Sep 2015 10:06:59 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NVHTVH-07-CXP-02 X-M-MSG: Message-ID: <560BEC77.8010400@amd.com> Date: Wed, 30 Sep 2015 09:06:47 -0500 From: Tom Lendacky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Geliang Tang CC: , Subject: Re: [PATCH] amd-xgbe: fix potential memory leak in xgbe-debugfs References: <636eed156113df40f9dd5e696f0486f428aff590.1443638366.git.geliangtang@163.com> In-Reply-To: <636eed156113df40f9dd5e696f0486f428aff590.1443638366.git.geliangtang@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(164054003)(24454002)(377454003)(479174004)(199003)(189002)(77156002)(5007970100001)(47776003)(19580405001)(62966003)(97736004)(80316001)(5004730100002)(19580395003)(4001350100001)(83506001)(5001860100001)(65806001)(92566002)(4001540100001)(64706001)(5001830100001)(65956001)(65816999)(87266999)(59896002)(76176999)(101416001)(50986999)(87936001)(64126003)(46102003)(106466001)(50466002)(105586002)(54356999)(86362001)(2950100001)(77096005)(68736005)(36756003)(33656002)(189998001)(110136002)(5008740100001)(11100500001)(23746002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0861;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0861;2:WfSRJBzzIWDg/qXB8Ap+Mvr+RZTuOT7rApIjRzoCTALmsC2QNwVbS8bOsF+NPYWbNn+zZzD0sDOff17sfOJENzA4fbyq8XaybAjy21b0EpulM0jHMqmdwkjPzEFFTklgmDHcnrkVj36+2548R6i74Ba1c3W422IzewLrzTDy71c=;3:zLKcZ5VhyWDyTwdpOOql5XbGXHjHKADNjj0XG1CJpgBwlUUs1v5HrXYYgfh/P63W9qyGkBGGVcgaAJj0sygnTt/PEm1BkN++jpneXm7Am/rk/yZvBn8P/o4SMQzAAIZ8QPW8VB2HAdm1oBCx5WbBnyuTYGxemp2oHRQ9ok8pvCWxQdQuNkG3ftqiS2mPXuOYgwMr6HI8Qy9DEJqUW3udWhqJzEwae6qOhGBLvu7iW5e21Fkx/4P5bJeuGH8mdChi;25:JDnfgyNkabcxEGyHWC8ffxZE5n1Whbs1lyxAXyfBClB6YZ5SQf94qg+45xivIH0S7QlVY5G6doeTPsFHaLdVHeAuMffbEeVM3xv0MscyQ7ns+He/+fbVrOBNgcVNlV8JXcp/JhsqpBLdegfJihXKpCTGepm6X7LWEGo0JCIwFR0xIDg/WSLmwGAxBluZRLZjqtvdd6L4d40aAAD4dsM+hiYXh6xeHTE01Dmx0hmT7svpYM+lrkeK/RrbXozMUssj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0861; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0861;20:8ocXpKroOprPaMjjPVoQWllpfFXwnCdCPSbmrRND9zDW9O1xa+SksYK0RTTmy4k+paWDRRrX9cvN3L/GH1mqcAuWPAAz5oXWbg0Rel3yr3BMIdnqjdFFxBWjezPyfAsv8FRnT0anND8GE4ZBdp8sy+ZNYgand1CcrSXQxFdvoLmm19B3WgIhe8pLNf61ShDSq5WgalKKHbJ6AvNlvNY4ME+HCxvPxtwDzjbV5ZOraeKbnxV4ct3uzlTLYAK8c3TlRd9XH2muENYbgN6abbe1PwTYqpFP2o2ggTP2rGjEW/3Oo+1aLjv1ff9eaMgO2inAvzp2UcvQiIvkzxk5ldV9JRkpFeDh9FXmOz/OQMD897dIiD0G8rY8+zbi8bcK5FNxWBLosjL0BpG9Oaee2U4dvv8yMbHw5DnuA+ot1j1YtkTvgMlldUnozljsVeSSsnUjWdL4MHlKJeyMPQeNr9HXsIVwU8jNIAhAIUUN+b2zGQctTsTBML1Ql42AR1QB4kT8;4:sI8tkia4Ik+DlT8ePYxB1Y+b4qJ7JgCC16M9KdordWWDDxrxFW4pNDtF9PTLzQC9GrX+7j6dZ6i4XWKsxXhowIAeiH0ICO/iumIrUmCsmBnUCkpLuC2eV+n6EEYyok2xceyARWFaWl0kBJzA7Vrl+D7RS/IBRYJb6rXdP61qUyRKaunPDdOqLRSMugFQ+yp2e2oC/rJVhhFzmLT+HdcNvUM4XTt/EysuNGEwSIayKHmyn/6lR2Bo3v9iuCgelaRlixyJ8a/JNmFxZWeP8oN5kR8dmKZMbCs3pASMe3UbLpvwoXkTKxxE13/hvAhYzw/tiWowTcFls3Qi3yC9eejA91vX8tB1ccTmaHazsWb486k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:SN1PR12MB0861;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0861; X-Forefront-PRVS: 071518EF63 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0861;23:S2wNfUgjdo6e5bMF51nmK1amqbLCZXv5A0bpv?= =?Windows-1252?Q?MVV/0loFwb2fgatbcQWoo6qhG4Mz3pzP3/OaBws8x6kjCtrSujRqedns?= =?Windows-1252?Q?/35zA0fXFckr2KBQbxmJECHz+yROTfze6JBY1RBscmQbF7rrF3p8Js2r?= =?Windows-1252?Q?4u89mIAqsm2hBR0GUYU4zQGdEdg3sqkglYLZJ1HSIbr0cFiUJi05tSzn?= =?Windows-1252?Q?R8qziY2qwtb/15gn1eLp9PEWrtjMA4NisQyevtokXkeVwFudshG9DJi7?= =?Windows-1252?Q?ZM5QAc7k8wVmu/P7gDw7Tehn0vGinFOndQCpXFUk6Za9YG8F3V81Lu1P?= =?Windows-1252?Q?5fJ3PVGKe/3ADtHRXvlK0sYm5hdF/jq3sL2H2jZOFQY0/UewpGjwm93+?= =?Windows-1252?Q?ZZCHk9gFqsuAcwU7o6t3zrNLGFh+QuKdVjWuFdsYNGzaEJAh1YzRJb3N?= =?Windows-1252?Q?nxj+gpMKWUHD52HN13gqfOnCZIwf2mxeiLWqcdJXkEP3CCwlbs0GgG31?= =?Windows-1252?Q?22ibax+kvI0gxPlFy27NP/mSZPxkF3RLAqO2E7GR9ex30IMniZZRs/oS?= =?Windows-1252?Q?7W5ahfUNoWlvWZ/+2lBXCMqSAQnZBdeKwRMxgftTfpfjpb2hud5XCCVb?= =?Windows-1252?Q?YTHL+mHG2ykgoOZGr0o8f1SjTXupfGwgDI05pazKIJldFyfkNklD6kDS?= =?Windows-1252?Q?ajbxog/QMNURP2A/iUK+yLe8RuuC34w46zJgXKI/Sp8E2pEETGlE1CWd?= =?Windows-1252?Q?w+T3KwWlGPbqYg3TGu1fv/DimtK9wvp7IkCshyUcjem3fRY2rRpVs2R4?= =?Windows-1252?Q?ZnYEyB9TiY2NYOmUu3/hG4ivjAfljUlRmiz/ANBOJsP4AF/9c7J7s2R1?= =?Windows-1252?Q?5g3LWoUITYGo8ZodS0mVJ1VLEq3ZJOjSeQscTGqVPVMoPBaWFznIv++W?= =?Windows-1252?Q?lCI1GGb/ZkWZiIAWnbcZL+oEHyBu3Podw8Bu1vx6/pqXREVTUY3cv/CD?= =?Windows-1252?Q?3cgEjQde2+jxxSMqmUOykVVqa5HrdPleQx5r9O5daEFoayskPfV5iyzZ?= =?Windows-1252?Q?86n8dCeVFFRVaqrXJdpZHpHfocwJjeQAV9arDE+xuZGhfi87taLJM6X7?= =?Windows-1252?Q?FgPdFyDbdsF8rO6J2CfNbyFC6jovEkjxGK/jYBxcPRHvIfY5XO01mdUm?= =?Windows-1252?Q?t2sA0jiQZWvq08f24R1i356IFEXVGhVlUIX6XUMQw4XlcHCpMyBihDdC?= =?Windows-1252?Q?JIkvyj9rq9F2TPcsT+NTsCtBmWHzyKQpwB8MX3D+uRVVujQ4ghLFh0Xu?= =?Windows-1252?Q?QD0nEzftF19/HhOyE/qVogSETlkMOjHrcKHufKEgaGfAnYnnsktwK+6O?= =?Windows-1252?Q?6ijs4bLOAdWiKzVB6vaTJgjLsIuJtA/yK+MnLOUzmwjiLPUtHgVNPGgM?= =?Windows-1252?Q?B0yAs35Utl3GMj9gkVjp4s/1LIAnfGWbIJ+/Jqk2A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0861;5:dnjiN9nuPf2ofSvTOK1I8d2bW2PLBFVvQVEbmXM0ahhDJt/2Xc9628RlmAurVHD2+SfTrvBqq8OAy5a1ruMO+qVWQBJbI0GgCc0MklNZ6bx47uZZvX5xey11YmfKf0y2RB10ZFqzcAhjdeZE5rJxZQ==;24:Z+9f7J7nVzBuPITvh+vqgz+NYHE5aijl3Ym3eBRFnssrwmBnyV8oR3rxZ7ICuoKMdUtQ2S4MSHpliQe/Vb3l7UpZmdWeG9hCNEJz2BV6bsY=;20:KWJLnJNukEKH0m9WT8yfx1o9r+dzsxyY8/9FW77FiNhC3RD0/bA8ESfExvtv36h289GolWvY88cMCYPFsX+Mlg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2015 14:06:55.1222 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0861 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2015 05:48 AM, Geliang Tang wrote: > Added kfree() to avoid the memory leak when debugfs_create_dir() fails. > > Signed-off-by: Geliang Tang Acked-by: Tom Lendacky > --- > drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c > index 2c063b6..66137ff 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c > @@ -330,6 +330,7 @@ void xgbe_debugfs_init(struct xgbe_prv_data *pdata) > pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL); > if (!pdata->xgbe_debugfs) { > netdev_err(pdata->netdev, "debugfs_create_dir failed\n"); > + kfree(buf); > return; > } > > Looking at the code, I should also check for buf being NULL before calling debugfs_create_dir. I'll work up a patch for that and send it in. Thanks, Tom