From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753755AbbI3O2V (ORCPT ); Wed, 30 Sep 2015 10:28:21 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:57661 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854AbbI3O2R (ORCPT ); Wed, 30 Sep 2015 10:28:17 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <560BF17E.6040806@mev.co.uk> Date: Wed, 30 Sep 2015 15:28:14 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Luis de Bethencourt , linux-kernel@vger.kernel.org CC: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, surya.seetharaman9@gmail.com, devel@driverdev.osusl.org Subject: Re: [PATCH v2] staging: comedi: ni_tiocmd: remove unused code References: <1443525723-6323-1-git-send-email-luisbg@osg.samsung.com> In-Reply-To: <1443525723-6323-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/15 12:22, Luis de Bethencourt wrote: > Code after a return will never run, removing this dead code. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > This is a better fix than the previous patch: > http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02741.html > > Suggestion of just removing the dead code was in: > http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02939.html > > Thanks, > Luis > > drivers/staging/comedi/drivers/ni_tiocmd.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c > index 9b124b0..437f723 100644 > --- a/drivers/staging/comedi/drivers/ni_tiocmd.c > +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c > @@ -157,12 +157,6 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s) > dev_err(counter->counter_dev->dev->class_dev, > "output commands not yet implemented.\n"); > return -ENOTSUPP; > - > - counter->mite_chan->dir = COMEDI_OUTPUT; > - mite_prep_dma(counter->mite_chan, 32, 32); > - ni_tio_configure_dma(counter, true, false); > - mite_dma_arm(counter->mite_chan); > - return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE); > } > > static int ni_tio_cmd_setup(struct comedi_subdevice *s) > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-