From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582AbbI3P4l (ORCPT ); Wed, 30 Sep 2015 11:56:41 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20578 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbbI3P4j (ORCPT ); Wed, 30 Sep 2015 11:56:39 -0400 Subject: Re: [PATCH net-next 3/3] RDS-TCP: Set up MSG_MORE and MSG_SENDPAGE_NOTLAST as appropriate in rds_tcp_xmit To: Sowmini Varadhan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <4471e1253cbbd917c1b1bd62b5b14844c19a857f.1443569239.git.sowmini.varadhan@oracle.com> Cc: davem@davemloft.net, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com, igor.maximov@oracle.com From: santosh shilimkar Organization: Oracle Corporation Message-ID: <560C0632.5060108@oracle.com> Date: Wed, 30 Sep 2015 08:56:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <4471e1253cbbd917c1b1bd62b5b14844c19a857f.1443569239.git.sowmini.varadhan@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2015 6:45 AM, Sowmini Varadhan wrote: > For the same reasons as 2f53384424 and 35f9c09fe9, rds_tcp_xmit > may have multiple pages to send, so use the MSG_MORE and > MSG_SENDPAGE_NOTLAST as hints to tcp_sendpage() > > Signed-off-by: Sowmini Varadhan > --- Your checkpatch.pl should have complained about commit reference in the change-log. You might want to fix that for consistency. Patch itself is fine. Acked-by: Santosh Shilimkar