From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933138AbbI3TDN (ORCPT ); Wed, 30 Sep 2015 15:03:13 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35862 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932481AbbI3TDL (ORCPT ); Wed, 30 Sep 2015 15:03:11 -0400 Message-ID: <560C31E4.2080007@dev.mellanox.co.il> Date: Wed, 30 Sep 2015 15:03:00 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "Weiny, Ira" CC: "dledford@redhat.com" , "xerofoify@gmail.com" , "linux-rdma@vger.kernel.org" , "Hefty, Sean" , "hal.rosenstock@gmail.com" , "jgunthorpe@obsidianresearch.com" , "yun.wang@profitbricks.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC] IB/mad: remove obsolete snoop interface References: <1443592864-32019-1-git-send-email-ira.weiny@intel.com> <560BDB97.8010908@dev.mellanox.co.il> <2807E5FD2F6FDA4886F6618EAC48510E1CBA2FA4@CRSMSX101.amr.corp.intel.com> In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E1CBA2FA4@CRSMSX101.amr.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2015 12:32 PM, Weiny, Ira wrote: >> >> On 9/30/2015 2:01 AM, ira.weiny@intel.com wrote: >>> From: Ira Weiny >>> >>> This interface has no current users and is obsolete. >> >> There are no in tree users of this but there is Sean's madeye tool (which is out >> of tree). This is still a useful debug tool for MADs. > > Where is that? It's been out of tree for some time now. For one place, it can be found on OpenFabrics site in some old and moldy OFED. > I did not think it was supported any longer? It still works AFAIK. > I have a series of about 5 patches which implement tracing in the MAD stack which I was working through and was going to submit Does your MAD stack tracing include the dumping and decode of sent and received MADs ? -- Hal > along with this patch (those are still being tested in my spare time). I just wanted put this out here because of the patch Nicholas posted yesterday. >> >>> Signed-off-by: Ira Weiny >>> --- >>> >>> This has undergone a medium level of testing. I have run it against >>> mlx4, qib, and OPA hardware and it does not seem to cause any regressions. >>> >>> drivers/infiniband/core/mad.c | 226 +------------------------------------ >>> drivers/infiniband/core/mad_priv.h | 13 --- >>> 2 files changed, 5 insertions(+), 234 deletions(-) >> >> There are also snoop changes needed in include/rdma/ib_mad.h. > > I'll look into it if there are no other objections to removing the snoop interface. > >> >> Is it correct to assume that OPA_CAP_MASK3_IsSnoopSupported in >> opa_port_info.h is not related to this ? > > Nope, not related. > > Ira > >