From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932980AbbI3VgU (ORCPT ); Wed, 30 Sep 2015 17:36:20 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34487 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932717AbbI3VgQ (ORCPT ); Wed, 30 Sep 2015 17:36:16 -0400 Message-ID: <560C55C2.3010906@gmail.com> Date: Wed, 30 Sep 2015 14:36:02 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Arun Parameswaran CC: "David S. Miller" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding References: <1443645163-2822-1-git-send-email-arunp@broadcom.com> <1443645163-2822-2-git-send-email-arunp@broadcom.com> In-Reply-To: <1443645163-2822-2-git-send-email-arunp@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/15 13:32, Arun Parameswaran wrote: > Add device tree binding documentation for the Broadcom iProc MDIO > bus driver. > > Signed-off-by: Arun Parameswaran > --- > .../devicetree/bindings/net/brcm,iproc-mdio.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt > > diff --git a/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt > new file mode 100644 > index 0000000..689f97c > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt > @@ -0,0 +1,23 @@ > +* Broadcom iProc MDIO bus controller > + > +Required properties: > +- compatible: should be "brcm,iproc-mdio" > +- reg: address and length of the register set for the MDIO interface > +- #size-cells: must be 1 > +- #address-cells: must be 0 > + > +Child nodes of this MDIO bus controller node are standard Ethernet PHY device > +nodes as described in Documentation/devicetree/bindings/net/phy.txt > + > +Example: > + > +mdio@0x18002000 { Sorry for not catching this earlier, you might want to drop the leading 0x here from your example, other than that: Reviewed-by: Florian Fainelli -- Florian