Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding

[Arun Parameswaran <aparames@broadcom.com>]

On 15-09-30 02:36 PM, Florian Fainelli wrote:
> On 30/09/15 13:32, Arun Parameswaran wrote:
>> Add device tree binding documentation for the Broadcom iProc MDIO
>> bus driver.
>>
>> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
>> ---
>>  .../devicetree/bindings/net/brcm,iproc-mdio.txt    | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt
>> new file mode 100644
>> index 0000000..689f97c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt
>> @@ -0,0 +1,23 @@
>> +* Broadcom iProc MDIO bus controller
>> +
>> +Required properties:
>> +- compatible: should be "brcm,iproc-mdio"
>> +- reg: address and length of the register set for the MDIO interface
>> +- #size-cells: must be 1
>> +- #address-cells: must be 0
>> +
>> +Child nodes of this MDIO bus controller node are standard Ethernet PHY device
>> +nodes as described in Documentation/devicetree/bindings/net/phy.txt
>> +
>> +Example:
>> +
>> +mdio@0x18002000 {
> Sorry for not catching this earlier, you might want to drop the leading
> 0x here from your example, other than that:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Will fix this.

Thanks,

Arun