From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692AbbI3VpP (ORCPT ); Wed, 30 Sep 2015 17:45:15 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:44062 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbbI3VpK (ORCPT ); Wed, 30 Sep 2015 17:45:10 -0400 X-IronPort-AV: E=Sophos;i="5.17,614,1437462000"; d="scan'208";a="76296016" Message-ID: <560C5803.1040907@broadcom.com> Date: Wed, 30 Sep 2015 14:45:39 -0700 From: Arun Parameswaran User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Florian Fainelli , Arun Parameswaran CC: "David S. Miller" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list Subject: Re: [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding References: <1443645163-2822-1-git-send-email-arunp@broadcom.com> <1443645163-2822-2-git-send-email-arunp@broadcom.com> <560C55C2.3010906@gmail.com> In-Reply-To: <560C55C2.3010906@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-09-30 02:36 PM, Florian Fainelli wrote: > On 30/09/15 13:32, Arun Parameswaran wrote: >> Add device tree binding documentation for the Broadcom iProc MDIO >> bus driver. >> >> Signed-off-by: Arun Parameswaran >> --- >> .../devicetree/bindings/net/brcm,iproc-mdio.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt >> >> diff --git a/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt >> new file mode 100644 >> index 0000000..689f97c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio.txt >> @@ -0,0 +1,23 @@ >> +* Broadcom iProc MDIO bus controller >> + >> +Required properties: >> +- compatible: should be "brcm,iproc-mdio" >> +- reg: address and length of the register set for the MDIO interface >> +- #size-cells: must be 1 >> +- #address-cells: must be 0 >> + >> +Child nodes of this MDIO bus controller node are standard Ethernet PHY device >> +nodes as described in Documentation/devicetree/bindings/net/phy.txt >> + >> +Example: >> + >> +mdio@0x18002000 { > Sorry for not catching this earlier, you might want to drop the leading > 0x here from your example, other than that: > > Reviewed-by: Florian Fainelli Will fix this. Thanks, Arun