From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754960AbbI3Xo6 (ORCPT ); Wed, 30 Sep 2015 19:44:58 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:43339 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbbI3Xoy (ORCPT ); Wed, 30 Sep 2015 19:44:54 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-fc-560c73f34ec4 Subject: Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support To: Doug Anderson References: <1443527855-434-1-git-send-email-javier@osg.samsung.com> <560B2D29.5060707@samsung.com> Cc: Javier Martinez Canillas , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab , Olof Johansson , Russell King , Kukjin Kim , "devicetree@vger.kernel.org" , Kumar Gala , Ian Campbell , linux-samsung-soc , Rob Herring , Pawel Moll , Mark Rutland , "linux-arm-kernel@lists.infradead.org" From: Krzysztof Kozlowski Message-id: <560C73EC.40608@samsung.com> Date: Thu, 01 Oct 2015 08:44:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t/xK7qfi3nCDH4v5beYf+Qcq8XZZQfZ LPrfLGS1OPdqJaPFm7drmCxevzC06H/8mtli0+NrrBaXd81hs5hxfh+Txe3LvBZLr19kslj9 rMLi1PXPbBYTpq9lsWjde4TdQcBjzbw1jB4tzT1sHrMbLrJ4XO7rZfJYufwLm8emVZ1sHpuX 1HtcOdHE6rGl/y67R9+WVYwenzfJBXBHcdmkpOZklqUW6dslcGUs2dTDXNDBXzFlyl7mBsbD 3F2MnBwSAiYSx25/YoKwxSQu3FvP1sXIxSEksJRRYtfBbywQzhdGib4V69hBqoQFHCTuTH8E ZosIaEo8a3jJDFG0hlHi5K53jCAOs8AcVolrXTvAqtgEjCU2L1/CBmLzCmhIvOi/zQJiswio Skw68pMVxBYViJA4dfYtVI2gxI/J98BqOAWCJb41TwXawAE0VF1iypRckDCzgLzE5jVvmScw CsxC0jELoWoWkqoFjMyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MUKi7ssOxsXHrA4xCnAw KvHwHkzhCRNiTSwrrsw9xCjBwawkwusEEuJNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB 9MSS1OzU1ILUIpgsEwenVAOjYsiqwKO5mYcSl75fMP/vEZf5VxlcdtzcnzVvVR2/vfDsCZJ6 4bun2X59eOrbTMGTVyYeTdvFdnGf+1KxH4mnJAp3+vtZLBFl4i2+E7r38RmeR5l/r8ZUGazQ 5nhg/7RZtL5W7NsyjaU6s18uezPv6YLcGbtn5J7k/fYn79b57Qeb94bOX/fHKUyJpTgj0VCL uag4EQCklNihtgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.10.2015 01:17, Doug Anderson wrote: > Hi, > > On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski > wrote: >> Now the exynos5250-snow.dts means in fact Rev4... but there is no >> information in DTS about it. I think adding compatible >> "google,snow-rev4" makes sense: >> 1. For informational purposes (this could be also handled with a comment). >> 2. Later one could decide to switch the default meaning of "google,snow" >> to Rev5 and the real compatible (rev4) will be there already. >> >> Could you add the new compatible and fix patch issues pointed by Doug? > > Looks like everything got applied, but just for the record: > > Switching the default meaning of "google,snow" to Rev5 is probably not > something we'd ever want to do, since it could confuse "rev3" boards > (which should be serviced by the rev4 dts). From comments in the > Chrome OS tree: > > In the "rev4" DTS: > * - Any real rev 0-3 boards in the field will match "google,snow", > * since older U-Boots don't look for a revision specific device tree. > * - Any real rev 4 boards in the field will match "google,snow-rev4" > * first. If that's not present they will pick the first > * "google,snow" device tree that they find (ignoring the kernel > * ordering). > > In the "rev5" DTS: > * - Purposely don't add "google,snow" so old firmware (which didn't > * include a -revN suffix) won't pick this one. These are requirements written somewhere in the downstream tree... not in upstream. Have in mind that someone may not be using Chrome OS on Chromebook but custom U-Boot and different distro. You cannot expect that everyone will new some requirements of some downstream OS. If you need such requirements, write them in bindings documentation *in the upstream*. Best regards, Krzysztof