From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932875AbbJAEl0 (ORCPT ); Thu, 1 Oct 2015 00:41:26 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:53687 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbbJAElW (ORCPT ); Thu, 1 Oct 2015 00:41:22 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-68-560cb96f79c1 Message-id: <560CB74E.7070909@samsung.com> Date: Thu, 01 Oct 2015 10:02:14 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Rob Herring Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JBottomley@odin.com, vinholikatti@gmail.com, amit.daniel@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCH v2 01/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC References: <1442483137-32376-1-git-send-email-alim.akhtar@samsung.com> <1442483137-32376-2-git-send-email-alim.akhtar@samsung.com> <56001538.5030706@kernel.org> In-reply-to: <56001538.5030706@kernel.org> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsWyRsSkVjd/J0+YQfd5SYuGqyEW84+cY7VY fmEJk8X/9bdZLC487WGzuLxrDptF9/UdbBb/9+xgt9ixsMqB02PnrLvsHptWdbJ5HP7xg9mj b8sqRo/jN7YzeXzeJBfAFsVlk5Kak1mWWqRvl8CV8ePnCpaCzVIVXfMesjcwHhDpYuTkkBAw kWhv2sYIYYtJXLi3nq2LkYtDSGAFo0T78p9sMEXf/s1jgkjMYpS43HSAHcJ5wCjxbd0msHZe AS2J5VO7wGwWAVWJe9NmgdlsAtoSd6dvAerm4BAViJB4fEEIolxQ4sfkeywgtoiAosTvtmms IDOZBe4xSnT2XgarFxYIkJh8JR9i11JGiZtH1zGDNHAC7Vrz+A5YM7OArcSC9+ugbHmJzWve MkNc/Yhd4tiHGoh7BCS+TT7EAjJTQkBWYtMBqBJJiYMrbrBMYBSbheSkWUimzkIydQEj8ypG 0dSC5ILipPQiQ73ixNzi0rx0veT83E2MwIg8/e9Z7w7G2wesDzEKcDAq8fBKpPOECbEmlhVX 5h5iNAW6YiKzlGhyPjDu80riDY3NjCxMTUyNjcwtzZTEeRWlfgYLCaQnlqRmp6YWpBbFF5Xm pBYfYmTi4JRqYJzxhdvh6ZbS2lWZaR9Dlp+M6WZROv7V6n/o02PlRTdWVkf+41+5xJL/HpOP t0qoNfvVPZIWpsz7zC7+9Hu2YlPWTcdXf2LfeuX9/qSSfjzBZN2amLPSzc5n3910n5f6Lm/T n/V7Wtrum8tqJT2dOt/y5rZ1sZ9tfbxfv/C5o20bGLTnF6PfBXslluKMREMt5qLiRACryYvu wwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jQd38nTxhBlce8Vs0XA2xmH/kHKvF 8gtLmCz+r7/NYnHhaQ+bxeVdc9gsuq/vYLP4v2cHu8WOhVUOnB47Z91l99i0qpPN4/CPH8we fVtWMXocv7GdyePzJrkAtqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8 xNxUWyUXnwBdt8wcoKOUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBk/ fq5gKdgsVdE17yF7A+MBkS5GTg4JAROJb//mMUHYYhIX7q1n62Lk4hASmMUocbnpADuE84BR 4tu6TYwgVbwCWhLLp3aB2SwCqhL3ps0Cs9kEtCXuTt8CNImDQ1QgQuLxBSGIckGJH5PvsYDY IgKKEr/bprGCzGQWuMco0dl7GaxeWCBAYvKVfIhdSxklbh5dxwzSwAm0a83jO2DNzAK2Egve r4Oy5SU2r3nLPIER6EyEHbOQlM1CUraAkXkVo0RqQXJBcVJ6rlFearlecWJucWleul5yfu4m RnDcP5PewXh4l/shRgEORiUe3gMpPGFCrIllxZW5hxglOJiVRHhztwCFeFMSK6tSi/Lji0pz UosPMZoCA2Eis5Rocj4wJeWVxBsam5ibGptamliYmFkqifPeOMQQJiSQnliSmp2aWpBaBNPH xMEp1cBotizE9mHZC2ffixNutk0oX7lw1xkOn5/z1Q5X3JdrNJhu6X3o6+ydvjc2HS+fuujA vGO7Lt/8t/ZJ+d5Tdu2Xu/9HqPXqu6d0LwueohNyUFEwVcbSKEPli1WAZkSRgqnlq3Plpf/+ VDtqFAec81h93q1/TsHrrB86rxpYT6R45Cepb/m8SmCHEktxRqKhFnNRcSIAYySWMhEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Rob, Thanks for your time. On 09/21/2015 08:03 PM, Rob Herring wrote: > On 09/17/2015 04:45 AM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> This patch introduces Exynos UFS PHY driver. This driver >> supports to deal with phy calibration and power control >> according to UFS host driver's behavior. >> >> Signed-off-by: Seungwon Jeon >> Signed-off-by: Alim Akhtar >> Cc: Kishon Vijay Abraham I >> --- >> .../devicetree/bindings/phy/samsung-phy.txt | 22 ++ > > It is preferred to put the binding in a separate patch. > Ok, will make a separate patch to add bindings. >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-exynos-ufs.c | 262 ++++++++++++++++++++ >> drivers/phy/phy-exynos-ufs.h | 85 +++++++ >> drivers/phy/phy-exynos7-ufs.h | 89 +++++++ >> include/linux/phy/phy-exynos-ufs.h | 107 ++++++++ >> 7 files changed, 573 insertions(+) >> create mode 100644 drivers/phy/phy-exynos-ufs.c >> create mode 100644 drivers/phy/phy-exynos-ufs.h >> create mode 100644 drivers/phy/phy-exynos7-ufs.h >> create mode 100644 include/linux/phy/phy-exynos-ufs.h >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 60c6f2a..1abe2c4 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> @@ -174,3 +174,25 @@ Example: >> usbdrdphy0 = &usb3_phy0; >> usbdrdphy1 = &usb3_phy1; >> }; >> + >> +Samsung Exynos7 soc serise UFS PHY Controller > > s/serise/series/ > ok >> +--------------------------------------------- >> + >> +UFS PHY nodes are defined to describe on-chip UFS Physical layer controllers. >> +Each UFS PHY controller should have its own node. >> + >> +Required properties: >> +- compatible : compatible list, contains "samsung,exynos7-ufs-phy" >> +- reg : offset and length of the UFS PHY register set; >> +- reg-names : reg name(s) must be 'phy-pma'; >> +- #phy-cells : must be zero >> +- samsung,syscon-phandle : a phandle to the PMU system controller, no arguments > > How about samsung,pmu-syscon as syscon can mean a variety of things? > agree, will change it. >> + >> +Example: >> + ufs_phy: ufs-phy@0x15571800 { >> + compatible = "samsung,exynos7-ufs-phy"; >> + reg = <0x15571800 0x240>; >> + reg-names = "phy-pma"; >> + samsung,syscon-phandle = <&pmu_system_controller>; >> + #phy-cells = <0>; >> + }; >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index 6b8dd16..7449376 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -358,4 +358,11 @@ config PHY_BRCMSTB_SATA >> Enable this to support the SATA3 PHY on 28nm Broadcom STB SoCs. >> Likely useful only with CONFIG_SATA_BRCMSTB enabled. >> >> +config PHY_EXYNOS_UFS >> + tristate "EXYNOS SoC series UFS PHY driver" >> + depends on OF && ARCH_EXYNOS > > || COMPILE_TEST > ok will add >> + select GENERIC_PHY >> + help >> + Support for UFS PHY on Samsung EXYNOS chipsets. >> + >> endmenu > >