From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756015AbbJAHgI (ORCPT ); Thu, 1 Oct 2015 03:36:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:53153 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755755AbbJAHgE (ORCPT ); Thu, 1 Oct 2015 03:36:04 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-41-560ce261fea9 Message-id: <560CE260.1000404@samsung.com> Date: Thu, 01 Oct 2015 09:36:00 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Maciek Borzecki Cc: linux-kernel@vger.kernel.org, Richard Purdie , linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH 2/3] leds: add debugfs to device trigger References: <560BECCE.6080304@samsung.com> <20150930154754.GA31149@corsair.lan> In-reply-to: <20150930154754.GA31149@corsair.lan> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xK7qJj3jCDO6+1rJ4cqCd0WJh2xIW i8u75rBZbH2zjtFiyppWZovdu56yOrB57Jx1l91jcd9kVo8983+wenzeJBfAEsVlk5Kak1mW WqRvl8CVceTOeeaCD6wV21/8Z21gvMnSxcjJISFgIrH52ydmCFtM4sK99WxdjFwcQgJLGSXO rZ/LCJIQEnjGKHF3bjiIzSugJbHgUhtYnEVAVWLa4mYmEJtNwFDi54vXYLaoQITEn9P7WCHq BSV+TL4HtkxEQF/ib8NeZpAFzAILGSUWnd0EViQsYCOxYO0+FojNNxglnq88B3YSJ9DU23cn g01lFrCWWDlpGyOELS+xec1b5gmMArOQLJmFpGwWkrIFjMyrGEVTS5MLipPScw31ihNzi0vz 0vWS83M3MUKC+ssOxsXHrA4xCnAwKvHwHkzhCRNiTSwrrsw9xCjBwawkwnvwHlCINyWxsiq1 KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwcnFINjIynLbzCbj2qEknqunhW 1qk7J6aUozjHpeQnd+zmFIm5+72P/f+psHhdzzm5+uPNO8QbamPP/nh7x+vW02nH701Umt18 RTfIff7h1sUT1+peLPrS0XWZ86zASfnV4sq8ZrtdKlme7Iv0f6hrZ9Q0//3OXt4VWm+aDc1m z9CdvGCN9cO/b+KX1ymxFGckGmoxFxUnAgDYLEZwZgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2015 05:47 PM, Maciek Borzecki wrote: > On 09/30 16:08, Jacek Anaszewski wrote: >> Hi Maciek, >> >> Please test your solution thoroughly before submitting >> the next version. Writing to debugfs register attribute >> fails due to lack of proper copying from user memory, >> which makes testing impossible. > > Hi, thanks for the comment. Indeed, I noticed the problem just after > sending the patch. Surprisingly this didn't fail on iMX6 for some > reason. > > Aside from the __user access problem, is the approach, in general, ok for > you or would you suggest that I changed something? At first glance the feature looks nice. I'll be able to say more after testing working version. -- Best Regards, Jacek Anaszewski