From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933592AbbJANA1 (ORCPT ); Thu, 1 Oct 2015 09:00:27 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:43353 "EHLO e17.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755614AbbJANAZ (ORCPT ); Thu, 1 Oct 2015 09:00:25 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: manoj@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Reply-To: manoj@linux.vnet.ibm.com Subject: Re: [PATCH 3/3] cxlflash: drop unlikely before IS_ERR_OR_NULL References: <03d18502ed7ed417f136c091f417d2d88c147ec6.1443667610.git.geliangtang@163.com> <7685ffa3f47126617d740292cf35bf92cda193c3.1443667610.git.geliangtang@163.com> To: Geliang Tang , "James E.J. Bottomley" , Michael Neuling , Wen Xiong , "Matthew R. Ochs" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Manoj Kumar Organization: IBM Message-ID: <560D2E62.7040600@linux.vnet.ibm.com> Date: Thu, 1 Oct 2015 08:00:18 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <7685ffa3f47126617d740292cf35bf92cda193c3.1443667610.git.geliangtang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100113-0041-0000-0000-000001B75FCF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geliang: Thanks for catching this. - Manoj Acked-by: Manoj Kumar On 9/30/2015 9:55 PM, Geliang Tang wrote: > IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. > > Signed-off-by: Geliang Tang > --- > drivers/scsi/cxlflash/superpipe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxlflash/superpipe.c b/drivers/scsi/cxlflash/superpipe.c > index f1b62ce..eb1b01e 100644 > --- a/drivers/scsi/cxlflash/superpipe.c > +++ b/drivers/scsi/cxlflash/superpipe.c > @@ -1307,7 +1307,7 @@ static int cxlflash_disk_attach(struct scsi_device *sdev, > } > > ctx = cxl_dev_context_init(cfg->dev); > - if (unlikely(IS_ERR_OR_NULL(ctx))) { > + if (IS_ERR_OR_NULL(ctx)) { > dev_err(dev, "%s: Could not initialize context %p\n", > __func__, ctx); > rc = -ENODEV; > @@ -1432,7 +1432,7 @@ static int recover_context(struct cxlflash_cfg *cfg, struct ctx_info *ctxi) > struct afu *afu = cfg->afu; > > ctx = cxl_dev_context_init(cfg->dev); > - if (unlikely(IS_ERR_OR_NULL(ctx))) { > + if (IS_ERR_OR_NULL(ctx)) { > dev_err(dev, "%s: Could not initialize context %p\n", > __func__, ctx); > rc = -ENODEV; >