Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c)

Randy Dunlap
2015-10-01T18:12:26Z

On 10/01/15 10:49, Borislav Petkov wrote:
> On Thu, Oct 01, 2015 at 10:39:32AM -0700, Randy Dunlap wrote:
>> On 09/30/15 23:50, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20150930:
>>>
>>
>>
>> on x86_64:
>>
>> ../arch/x86/ras/mce_amd_inj.c: In function 'toggle_nb_mca_mst_cpu':
>> ../arch/x86/ras/mce_amd_inj.c:214:42: warning: dereferencing 'void *' pointer [enabled by default]
>> struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
>> ^
>> ../arch/x86/ras/mce_amd_inj.c:214:42: error: request for member 'misc' in something not a structure or union
>
> Thanks Randy,
>
> this is most likely due to us using node_to_amd_nb() - an AMD_NB
> facility - but we're not depending on it. Does that help?

Yes, thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> diff --git a/arch/x86/ras/Kconfig b/arch/x86/ras/Kconfig
> index 10fea5fc821e..98b3ef750984 100644
> --- a/arch/x86/ras/Kconfig
> +++ b/arch/x86/ras/Kconfig
> @@ -1,6 +1,6 @@
> config AMD_MCE_INJ
> tristate "Simple MCE injection interface for AMD processors"
> - depends on RAS && EDAC_DECODE_MCE && DEBUG_FS
> + depends on RAS && EDAC_DECODE_MCE && DEBUG_FS && AMD_NB
> default n
> help
> This is a simple debugfs interface to inject MCEs and test different
>

--
~Randy