From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751024AbbJAWM0 (ORCPT ); Thu, 1 Oct 2015 18:12:26 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36142 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbJAWMY (ORCPT ); Thu, 1 Oct 2015 18:12:24 -0400 Subject: Re: [RFC/PATCH 00/11] arm: omap: counter32k rework To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1443559446-26969-1-git-send-email-balbi@ti.com> <20150930141338.GC31865@saruman.tx.rr.com> <3705422.OMk7ysE7Jn@wuerfel> <6944324.e1oo8C9xbx@wuerfel> Cc: balbi@ti.com, Alexandre Courbot , Stephen Warren , Tony Lindgren , Linux Kernel Mailing List , Thierry Reding , linux-tegra@vger.kernel.org, tglx@linutronix.de, Linux OMAP Mailing List From: Daniel Lezcano Message-ID: <560DAFC5.50003@linaro.org> Date: Fri, 2 Oct 2015 00:12:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <6944324.e1oo8C9xbx@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2015 04:49 PM, Arnd Bergmann wrote: > On Wednesday 30 September 2015 16:42:21 Arnd Bergmann wrote: >> >> TEGRA folks: the tegra_read_persistent_clock() implementation apparently >> predates the Tegra RTC driver and I wonder if they actually do the >> right thing in combination. Could it be that the wall time forwards >> twice as fast as it should during resume when the RTC driver is loaded? >> Could it be that we can simply remove tegra_read_persistent_clock() >> and the register_persistent_clock() infrastructure? >> > > I found the 'sleeptime_injected' variable now, which takes care of > forwarding the clock by the correct amount. > > I also found the CLOCK_SOURCE_SUSPEND_NONSTOP flag next to it, which > should let us use the counter32k driver to provide the correct > time during suspend without the omap_read_persistent_clock() function. > We should be able to just delete that code. > > If we decide to also delete the tegra_read_persistent_clock() > function, we can remove the registration too. +1 -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog