From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbbJBADh (ORCPT ); Thu, 1 Oct 2015 20:03:37 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:59943 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbJBADf (ORCPT ); Thu, 1 Oct 2015 20:03:35 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f796f6d0000014a4-10-560dc9d5580f Content-transfer-encoding: 8BIT Message-id: <560DC9D4.2000301@samsung.com> Date: Fri, 02 Oct 2015 09:03:32 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sudip Mukherjee , Lukasz Majewski , Zhang Rui , Eduardo Valentin , Kukjin Kim , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] thermal: exynos: fix register read in TMU References: <1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> In-reply-to: <1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsWyRsSkWPfqSd4wg3tvOS3mX7nGavH6haFF /+PXzBZvHm5mtNj0GCh0edccNovPvUcYLWac38dk8eRhH5vFgdNTmB24PHbOusvusXjPSyaP Tas62Tw2L6n36NuyitHj8ya5ALYoLpuU1JzMstQifbsEroy7TZeYCiZwVlz8PoG1gfE0excj J4eEgInEnB3vGCFsMYkL99azgdhCAisYJe7dUYapOdz/grmLkQsovpRR4ujHK2DNvAKCEj8m 32PpYuTgYBaQlzhyKRskzCygLjFp3iKo+geMEudfXmCEqNeSWPDxBzOIzSKgKnH/2jsmEJsN KL7/xQ02kDmiAhES3ScqQXpFBL4zStyZ+JsdxGEWaGWUWPryE9ggYQE7iUsXmhkhLvWU2Lz1 ONjVnAJeEse23gDbLCHwlV3iZdtWdohtAhLfJh8Cu1RCQFZi0wFmiM8kJQ6uuMEygVFsFpJ/ ZiH8MwvJPwsYmVcxiqYWJBcUJ6UXGesVJ+YWl+al6yXn525iBEbm6X/P+ncw3j1gfYhRgINR iYdXIp0nTIg1say4MvcQoynQEROZpUST84Hxn1cSb2hsZmRhamJqbGRuaaYkzrtQ6mewkEB6 YklqdmpqQWpRfFFpTmrxIUYmDk6pBkZG9sd/Ow/wt67a+2uF003hhO6sTu2Of6W1D7ZdbAqJ nFkpEbJh11ylFRL711VkC0zfaHuduXSTkP/T4qjkLdvUpLOWnrBdL+lwwrHkYqLJubOTbb81 KMxpMZp99dK0+4/0y1V/BVoKp0qsUjcrCI6L72L/Gjh/Qmpw/P5dReIndluLFFrJ3ldiKc5I NNRiLipOBADCynTPxwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42I5/e+xgO7Vk7xhBn27WSzmX7nGavH6haFF /+PXzBZvHm5mtNj0GCh0edccNovPvUcYLWac38dk8eRhH5vFgdNTmB24PHbOusvusXjPSyaP Tas62Tw2L6n36NuyitHj8ya5ALaoBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sL cyWFvMTcVFslF58AXbfMHKDLlBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGE NYwZd5suMRVM4Ky4+H0CawPjafYuRk4OCQETicP9L5ghbDGJC/fWs3UxcnEICSxllDj68QpY Ea+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+AaPE+ZcXGCHqtSQWfPwBNpRFQFXi /rV3TCA2G1B8/4sbbCBzRAUiJLpPVIL0igh8Z5S4M/E3O4jDLNDKKLH05SewQcICdhKXLjSD 2UICnhKbtx5nA7E5Bbwkjm29wTyBUWAWkvtmIdw3C8l9CxiZVzFKpBYkFxQnpeca5aWW6xUn 5haX5qXrJefnbmIEx/8z6R2Mh3e5H2IU4GBU4uE9kMITJsSaWFZcmXuIUYKDWUmEd/d+3jAh 3pTEyqrUovz4otKc1OJDjKZAD05klhJNzgemprySeENjEzMjSyNzQwsjY3Mlcd4bhxjChATS E0tSs1NTC1KLYPqYODilGhi7TV74z/Z43lty3P9HGGcGq4WYvuPeqvLLNR0pLXMWr4o++Gzu YbcXh0Ka59ZEbf682Hy2/l81FsPiMzcWH/HVaz7Vu7z92Y/gI/NlD91P+JfW1Rn4v3Su9ydZ mcsHrlsHRt/Q3NQdah90aJFOENOsEGPLY7aXIud/E+9gCdN72ZZwMqC0kV2JpTgj0VCLuag4 EQBq8ydnFQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 10월 01일 20:39, Sudip Mukherjee wrote: > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. > > Signed-off-by: Sudip Mukherjee > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc..ca920b0 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > Thanks for your point out. Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi