From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752158AbbJBMK7 (ORCPT ); Fri, 2 Oct 2015 08:10:59 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33487 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbbJBMK6 (ORCPT ); Fri, 2 Oct 2015 08:10:58 -0400 Subject: Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found To: Andrew Lunn References: <560B9B7C.9080406@baylibre.com> <560D50E4.6040400@baylibre.com> <20151001163257.GQ20219@lunn.ch> Cc: "David S. Miller" , Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: <560E744E.4010502@baylibre.com> Date: Fri, 2 Oct 2015 14:10:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151001163257.GQ20219@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/2015 06:32 PM, Andrew Lunn wrote: > On Thu, Oct 01, 2015 at 05:27:32PM +0200, Neil Armstrong wrote: >> On 09/30/2015 10:21 AM, Neil Armstrong wrote: >>> If no switch were found in dsa_setup_dst, return -ENODEV and >>> exit the dsa_probe cleanly. > > ... > >> Couldn't we use the probe defer mechanism here ? (until complete rework is done) > > Hi Neil > > I was thinking the same last night. We know the switch should be > there, otherwise it would not be in DT. So returning -EPROBE_DEFER > would be valid. > > Andrew > Hi, It makes sens but does a module insertion triggers the differed probe ? I will still post this change in a next set of patch. Neil