From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbbJBXjI (ORCPT ); Fri, 2 Oct 2015 19:39:08 -0400 Received: from mail-bn1bon0062.outbound.protection.outlook.com ([157.56.111.62]:6622 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750709AbbJBXjF (ORCPT ); Fri, 2 Oct 2015 19:39:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <560F158C.4040303@caviumnetworks.com> Date: Fri, 2 Oct 2015 16:38:52 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yinghai Lu CC: David Daney , Linux Kernel Mailing List , "linux-pci@vger.kernel.org" , Bjorn Helgaas , "Michael S. Tsirkin" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , , "Sean O. Stalley" , Rajat Jain , "gong.chen@linux.intel.com" , David Daney Subject: Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources. References: <1443825476-26880-1-git-send-email-ddaney.cavm@gmail.com> <1443825476-26880-4-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0015.namprd07.prod.outlook.com (10.141.52.143) To BN4PR07MB2130.namprd07.prod.outlook.com (25.164.63.12) X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;2:o/m49zUuaZf4zBhPfUqdHdNH6jTYMbLoXLaR/LAT5CaOsf4ZLIv282bcE2HudEx0BAqKwVnx9gZw3QiU9JnXXvMLDp8igTiA/7riMNbWBH4bMrMnsYTR2cGLf1ADgNt7vizMl2506IPnKR7trBiqnG30CKeYbkhTQonWiAC4i6c=;3:YZ5vydLbl/+BcVNELTMJAiI1UxTr82idRTE+2TvYvs23cZ62sOni8DxJIYMvyL1sUTZy3YpVsuO3EEenFjnweBw2pADxGHEOkY1BYwS/6bAV8I3yqjiDZBbpIHAwz2RN4rO8FFNVXJN4XfXWj0llJw==;25:UN5W0zeB7S9gl/GQX3pchWt84u2J+VOAe3nnx/VUOxfLgVRrr7oTm8xqWk2aRCNlAdnnfP0kCrSMtLB7jswdTtp7Q5p/ttappQvM6QwuhNthJXEnH9uOfInLNqupi38ZVFHq7sNn3+aPWHWTeBLqznek2p4Vq9tK+RSLF5zcsifxudvvMBYZqY5cgAQmINsBqRW4Vqs7gbVnmp04wjqx55QmfpsnQoPnq/t0L0+lsl0muIVq2ssGnU7afK68DB/S X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;20:+9HW+c9gHT0Q9lN275H9Tb7V6yEkTncuKiaH98o63gF+0IZboNtbSc6UHUovHnrv0a0qsrRTLJZOmJcNpWeX+3o60jqKY/TVu2aFOuBiENcVoEMWosonHvVKylvHDK6/7l34mS91vaHx1M1oPYjlkSTWU7C0v+tvTr1o6BkldLVYtHC5CyvA9VJYFehylbYR0v9MSQoSFOFOftS2itfwyWm+I2lt7ozMpdwgFsrNEpAhEHMorEu8MZUiCVR5CZGy6/IUsSwfV/atNaRkPPtdng+j+lUsC9vlMCBja5fzW0k1tnL/MvGrc8jB060/3Hxm2URTksbqQxaMlUyRVmkiBaTlst8aE6wYHUw0cR0TrwZLVT52POT8yzK4w1gqDuq3UGiiR6V0NxH0NayxKsXRMVScDB20kQsA8pix5GcJDrdNbQBYAq8rFGWZTdHW52PRw/zRJ6/GEvp91uUKK9akrQW6zoCuyRqjXEOMRWl5d1WX7RWaT8MXJ/ES2a4V7Da2wYD/tXAOvb07dsed2t0QhU6dZDuAiNuDsM7B1GTMJfsHRabKJxcoGqp7PlKMNcBdVdkXlgXNxSHeB8YvLojSLo4ILzU0sajhcbu1H08TYj8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BN4PR07MB2130;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;4:ZikK8Cu4cJe6v4THFx78Xoeg5itTxiLiNf4Cbhfr0SGGfMgS7ELCGBpxwlMSWA0SVyQvpjLxkHq2xB2ooVdTB46Zvude3VjYv2lTyCe+HHyCyoiNHT8+YniC7vge0nlv8hP9ATeiCzjTH4EhFMPGOxdzxpZ50pimMpRSPMTK4CFI/2Nu/Ev1Ajr8oO0pJmADSVauFW8pjl889bEMES+LLqEl40SGRytuV077nXRp252uvFe/JBKCWWEYkuNWmngnmhFWpV7FzCBFe9TyRDfFqz8FZsvLwOhWtjtvmd6MzGUlgdUpkhHH8g9E/AYO3R4Vshk2MFFAJd0Ri+fx8dXKSssfnEd1It4lbaLrl1ZIobQ= X-Forefront-PRVS: 0717E25089 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(479174004)(164054003)(377454003)(199003)(24454002)(81156007)(65806001)(77156002)(5001830100001)(4001350100001)(122386002)(69596002)(62966003)(19580395003)(97736004)(47776003)(5001860100001)(19580405001)(40100003)(59896002)(4001540100001)(83506001)(101416001)(5008740100001)(65956001)(189998001)(64706001)(80316001)(66066001)(87976001)(106356001)(33656002)(77096005)(53416004)(105586002)(46102003)(64126003)(110136002)(42186005)(2950100001)(65816999)(50986999)(54356999)(76176999)(50466002)(5004730100002)(5001960100002)(87266999)(23676002)(36756003)(5007970100001)(68736005)(15975445007)(92566002)(3076002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2130;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjA3TUIyMTMwOzIzOk4xMkNyZHJ5RDdLSk8yTGhkZmgyRDNqUkd5?= =?utf-8?B?WSt6b1B1dm5kZVMydUo1MTdIMDNSVEFyYWJLOFNRMWNleUFPZzBpbHAyQlJt?= =?utf-8?B?WFd5Tzg1VlkzRjBjSFRQaEZpTURIeG1lNkM1Ykc3NDk0ZjcxL3lEQ3lKcFlN?= =?utf-8?B?SkpxcUN0MC9XczB6empxc2hrdEdBTE0xZ3NIRXI0aFdrejhIOVdNTzJJdVg3?= =?utf-8?B?bTlHVjRwamZaWnFNK0pHZzVFYWc3OHRzWE1xdDdVTVJuNTJ0K3ljVHVaczlF?= =?utf-8?B?NzNPd2ZFcGJrODhVMXFQZVFMTHpXNlhqeW9meXpkeTlQTHV1T0JLRGJXcnhu?= =?utf-8?B?a0lLZ1ZvMGE1akJQQzJYcE1nVXIxK2VnZG1Db1NpcXZPdkttTmdQUGg2RUVr?= =?utf-8?B?R3Rpelc4cFVhdFNhclR0c1plU1d6WGZoSnQ0V1g4eFE0blJPYVAxcURqa2Q3?= =?utf-8?B?eHU5cUd6cDA3citwZ3ZRR2tlTUptNG04ZU92RHlPUFh2OUhJVnFCcVJWL1hU?= =?utf-8?B?VVI0cTVzV0pPbHNUbmpYcXQzUTdFTjVwUTRjYmx5UUl1Qkkza3FaSFJIdE9V?= =?utf-8?B?QUpRZDcwaEtOM2pVemtkZi9ZVmxyb1JSQ3lNNDk2SVRTYWlES0J1OXNhOEtM?= =?utf-8?B?TlZhaE1QdEdyWTFtenFMZXE1dmZ6K3NJeStOQXRUdkhhWTJOaG54WDk3eWlV?= =?utf-8?B?OTJ0Z2ZuempCTlZCdkw5RWl2RE5WSXR3N3lVa29YSm4ySFhWeHVmbXU4RnNm?= =?utf-8?B?dUJ6enZuanVKbnBQRTVKRS8zQjEyWEViVlFZQ1c2U0tEVGVPc0RTcVdoZGJo?= =?utf-8?B?MkF2SnVDeTk3eTFWbklpZjZacGdHVVhDU3N1ZlFrSFhud0RxQWxVeisxVGNv?= =?utf-8?B?NzJmS3c4UWphaUxJeDZhL3ZjcEhud2VtQXJHa1ppU0hhT0craVp3Z1plRFcx?= =?utf-8?B?S01zbVFxMHh2N2xOZkRPM2NtdXBWT3ZQakg0WUE3M2xva3RVZTFtWDVQU0lh?= =?utf-8?B?aFVKRUxYR2VqdmZkcDdjdVltNU5qZklmSjN6YjFwcm14c1U2YUFGTFhJcTV1?= =?utf-8?B?WVRDTU1Gc25VeFQ1RUwyUlBoZElFOU9FOWdKY3lQbDFPOUlWNXZ3MzJnMzg5?= =?utf-8?B?czIvTnNaR1hJR2kwRktVOVVpUnowdVplcFI0ZlVXYmRGbTU3UE9vb254dGww?= =?utf-8?B?ajJXSUFqRWR3aTVFRUJlRVFGbXNaSHd0SnFlVkd4ejY0akF0QStPc2hyVFhT?= =?utf-8?B?L1VqZU5pQjFiRTZmamduM05QZXZ6TmtQY3dpNjRaOGZ3MDJ4NER2WkJuMjdR?= =?utf-8?B?WUVzVjNXRnpwaDNrRkJ4U2dWUnpKMGN0QmFxWTlMbnJpbEJDTjNETS81ekZE?= =?utf-8?B?UGxyb1VXbWhPWFcrbWxWM1FLYXlVaUpoVjgxUnRDNkNNNXVXalJZaWFHRGJR?= =?utf-8?B?L0NRbDNydFVPWVJNVHlEVkl2cVNhSUNMa3FibW14UGZaM2Y0TWk1QkJkVWFW?= =?utf-8?B?cWV0T2g2anh2ZWkzVDZwUEtINndjMDJ5c2lKMnppSDk4dnBNQUxUZEs3Umh4?= =?utf-8?B?TmxwczZUenRFMHV5RTNpZ2FobVZpcDVHNDViektQU2dEV2tNOWtUcWxkSE5k?= =?utf-8?B?VGptRGxvaUxhTDZuUkZHanZYZlpoVkkrK2I3NGtQTisrckgxdVhhUy9DTEN4?= =?utf-8?B?ZGNpYkRKUE9KVktjL0F4Lzc4dnJOTU5iTW5UQWtqeS96d0V2ZTBSSGVMN200?= =?utf-8?B?Ulp5VFVmSjhkYkNCbVN4dTJwWWt4dld4aWFzVlhyVlh4ekxJQTRubndQcHpk?= =?utf-8?B?aXNvNGlkRTh5VlpDVFlWTWxsT2VMVmFuRDI2cHB1RzBDWUdkY1Fxb2FFTjNZ?= =?utf-8?B?R3BSengxVko2YzFOL1ZYRzFqRjBETTIrYWg0MVAvSUwxSjVwUE5vQmNwQTVn?= =?utf-8?B?YnRGdVRlNHZwQ3k2Y3U5aXdHbWN2ZDV5UndmbktOa2N2TjFxd0VoTnJDd3F3?= =?utf-8?B?a3Nnd3FJYUdmdTczc0pJdGxnTUJNVHg1K2t0UT09?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;5:BnsZo0g+e49C5tgnQFX2oH2O5qEtAXYn/GpJWeUXkesC4PIX5OMsBLYpMSzdL6Amo50FkOcQHBH42ysneER26TKQqf2T8PYVQ3xqMtzODSYmL9u7Pl/WLPq/lhAYe8jLsl0/0bCtzpAB9EW/AMQ8TQ==;24:ZgTxG7+aHmb+ENPPk1AGMJoKhCdeKfyOhH9q1OqdfSsUi4OIx7V4niPCbrsDNJNxyk2vyH/i34QGzxzLvT2V+QqgYbMXp2FAKsxclAvZhlU=;20:bbVn8Z1agJpwMM5xIqp+i9k9coGkgXuePjyeW4675uw1yBDupN2+uxNnbQYOAsupAxLqaG1k0eegcZESqdlKkw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2015 23:38:57.7499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2130 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2260;2:Orvdiayl7SxZFscEzrdTTUtvop3L1n4MHKqZzI+9KouESB4XTY+UUFY/0saWBTIooWoikCn+i8XrJPrVTKPp3FnbrdkGoy7S2Ssj/2Td5gYsI+j020S0CY/n56Z5/cbfMDwkBV2P4spxK1uCxtwlGeeyAmpRu25MjPwTXfmWwzo=;23:bO9ovQgP1OJVmDIGqPi3OGJ23Q1N3vemo0/ltnfrdPMKnORTmJT5SmDQ6/qQmNbC2qnbpH3FwmSGuwikEHnFotx0afR17AxtMqXk1jg2u5tCi3NK0rvtL7Tq1xtxWG+nQxoodxfKjXzgDosdQTIeLbKwwExZ+2vM4kERObkcUshb3vL4AT0PxYf4huQrJjBY X-OriginatorOrg: caviumnetworks.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2015 04:14 PM, Yinghai Lu wrote: > On Fri, Oct 2, 2015 at 3:37 PM, David Daney wrote: >> From: David Daney >> >> The new Enhanced Allocation (EA) capability support creates resources >> with the IORESOURCE_PCI_FIXED set. This creates a couple of problems: >> >> 1) Since these resources cannot be relocated or resized, their >> alignment is not really defined, and it is therefore not specified. >> This causes a problem in pbus_size_mem() where resources with >> unspecified alignment are disabled. >> >> 2) During resource assignment in pci_bus_assign_resources(), >> IORESOURCE_PCI_FIXED resources are not given a parent. This, in >> turn, causes pci_enable_resources() to fail with a "not claimed" >> error. >> >> So, in pbus_size_mem() skip IORESOURCE_PCI_FIXED resources, instead of >> disabling them. >> >> In __pci_bus_assign_resources(), for IORESOURCE_PCI_FIXED resources, >> try to request the resource from a parent bus. > > Can you check if > > https://patchwork.kernel.org/patch/7304971/ > [v6,05/53] PCI: Don't release fixed resource for realloc This one isn't relevant as the problem is seen when we are acquiring resources, not releasing them. > > https://patchwork.kernel.org/patch/7304371/ > [v6,06/53] PCI: Claim fixed resource during remove/rescan path This one is interesting, but I don't think it will work. pci_claim_resource() calls pci_find_parent_resource(), which will fail in important use cases. It is perfectly legal for a bridge provisioned by EA to not specify any resources. In this case we must walk up the bus tree until we find something that contains the device resource, and can thus be a parent. That is a big part of what my patch is doing. As for the merits of assigning fixed resources from the FINAL fixup, rather than in __pci_bus_assign_resources(), I am unsure. Thanks, David Daney > > address the the problem that you met? > > Yinghai >