From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: mchehab@kernel.org, Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: ezequiel@vanguardiasur.com.ar, benjamin.gaignard@collabora.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] media: Fix P010 tiled format description
Date: Sat, 15 Oct 2022 11:01:06 +0200 [thread overview]
Message-ID: <5610120.DvuYhMxLoT@kista> (raw)
In-Reply-To: <f7200ae5-cefd-af98-d607-272915971f53@xs4all.nl>
Dne sobota, 15. oktober 2022 ob 10:59:28 CEST je Hans Verkuil napisal(a):
> Hi Jernej,
>
> On 10/15/22 10:56, Jernej Skrabec wrote:
> > There is only 31 bytes of space (without null character) for format
> > description. P010 tiled format description overflows that for 1
> > character and warning is generated when used. Fix that by changing Cb to
> > U and Cr to V, which is also consistent with some other descriptions.
> >
> > Fixes: 3c8e19d3d3f9 ("media: Add P010 tiled format")
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > ---
> >
> > drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> > b/drivers/media/v4l2-core/v4l2-ioctl.c index e6fd355a2e92..5e5616d5915a
> > 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1357,7 +1357,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc
> > *fmt)>
> > case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4
Linear)"; break;
> > case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16
Linear)";
> > break;
> > case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32
Linear)";
> > break;>
> > - case V4L2_PIX_FMT_P010_4L4: descr = "10-bit Y/CbCr 4:2:0
(4x4 Linear)";
> > break; + case V4L2_PIX_FMT_P010_4L4: descr = "10-bit Y/UV 4:2:0
(4x4
> > Linear)"; break;>
> > case V4L2_PIX_FMT_NV12M: descr = "Y/CbCr 4:2:0 (N-C)";
break;
> > case V4L2_PIX_FMT_NV21M: descr = "Y/CrCb 4:2:0 (N-C)";
break;
> > case V4L2_PIX_FMT_NV16M: descr = "Y/CbCr 4:2:2 (N-C)";
break;
>
> Sorry, I wasn't clear on irc: you should replace Cb and Cr with UV for ALL
> these descriptions.
>
> That way all the pixelformat descriptions use the same terminology and it
> fixes your issue as well.
Ok, will do.
Best regards,
Jernej
prev parent reply other threads:[~2022-10-15 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 8:56 [PATCH] media: Fix P010 tiled format description Jernej Skrabec
2022-10-15 8:59 ` Hans Verkuil
2022-10-15 9:01 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5610120.DvuYhMxLoT@kista \
--to=jernej.skrabec@gmail.com \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox