From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbbJEIXG (ORCPT ); Mon, 5 Oct 2015 04:23:06 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:51986 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752030AbbJEIXE convert rfc822-to-8bit (ORCPT ); Mon, 5 Oct 2015 04:23:04 -0400 From: Vincent ABRIOU To: Thierry Reding , "dri-devel@lists.freedesktop.org" CC: "linux-kernel@vger.kernel.org" , Benjamin Gaignard Date: Mon, 5 Oct 2015 10:22:53 +0200 Subject: Re: [PATCH 6/6] drm/sti: Do not export symbols Thread-Topic: [PATCH 6/6] drm/sti: Do not export symbols Thread-Index: AdD/Rwg7vbyfhTHCS0mkE1BCcghvww== Message-ID: <5612335D.5060403@st.com> References: <1443114161-7965-1-git-send-email-thierry.reding@gmail.com> <1443114161-7965-6-git-send-email-thierry.reding@gmail.com> In-Reply-To: <1443114161-7965-6-git-send-email-thierry.reding@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 acceptlanguage: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-10-05_03:2015-10-03,2015-10-05,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, Ack-by: Vincent Abriou BR Vincent On 09/24/2015 07:02 PM, Thierry Reding wrote: > From: Thierry Reding > > None of these exported symbols are used outside of the drm-sti driver, > so there is no reason to export them. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/sti/sti_crtc.c | 3 --- > drivers/gpu/drm/sti/sti_mixer.c | 1 - > drivers/gpu/drm/sti/sti_plane.c | 3 --- > drivers/gpu/drm/sti/sti_vtg.c | 6 ------ > 4 files changed, 13 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c > index 87bb4096b9d7..342d8a617c6f 100644 > --- a/drivers/gpu/drm/sti/sti_crtc.c > +++ b/drivers/gpu/drm/sti/sti_crtc.c > @@ -318,7 +318,6 @@ int sti_crtc_enable_vblank(struct drm_device *dev, unsigned int pipe) > > return 0; > } > -EXPORT_SYMBOL(sti_crtc_enable_vblank); > > void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe) > { > @@ -339,7 +338,6 @@ void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe) > compo->mixer[pipe]->pending_event = NULL; > } > } > -EXPORT_SYMBOL(sti_crtc_disable_vblank); > > static struct drm_crtc_funcs sti_crtc_funcs = { > .set_config = drm_atomic_helper_set_config, > @@ -360,7 +358,6 @@ bool sti_crtc_is_main(struct drm_crtc *crtc) > > return false; > } > -EXPORT_SYMBOL(sti_crtc_is_main); > > int sti_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer, > struct drm_plane *primary, struct drm_plane *cursor) > diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c > index 0182e9365004..4c18b50d71c5 100644 > --- a/drivers/gpu/drm/sti/sti_mixer.c > +++ b/drivers/gpu/drm/sti/sti_mixer.c > @@ -58,7 +58,6 @@ const char *sti_mixer_to_str(struct sti_mixer *mixer) > return ""; > } > } > -EXPORT_SYMBOL(sti_mixer_to_str); > > static inline u32 sti_mixer_reg_read(struct sti_mixer *mixer, u32 reg_id) > { > diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c > index d5c5e91f2956..2e5c751910c5 100644 > --- a/drivers/gpu/drm/sti/sti_plane.c > +++ b/drivers/gpu/drm/sti/sti_plane.c > @@ -42,7 +42,6 @@ const char *sti_plane_to_str(struct sti_plane *plane) > return ""; > } > } > -EXPORT_SYMBOL(sti_plane_to_str); > > static void sti_plane_destroy(struct drm_plane *drm_plane) > { > @@ -108,7 +107,6 @@ void sti_plane_init_property(struct sti_plane *plane, > plane->drm_plane.base.id, > sti_plane_to_str(plane), plane->zorder); > } > -EXPORT_SYMBOL(sti_plane_init_property); > > struct drm_plane_funcs sti_plane_helpers_funcs = { > .update_plane = drm_atomic_helper_update_plane, > @@ -119,4 +117,3 @@ struct drm_plane_funcs sti_plane_helpers_funcs = { > .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, > }; > -EXPORT_SYMBOL(sti_plane_helpers_funcs); > diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c > index d8bd8b76b1fa..d56630c60039 100644 > --- a/drivers/gpu/drm/sti/sti_vtg.c > +++ b/drivers/gpu/drm/sti/sti_vtg.c > @@ -110,7 +110,6 @@ struct sti_vtg *of_vtg_find(struct device_node *np) > } > return NULL; > } > -EXPORT_SYMBOL(of_vtg_find); > > static void vtg_reset(struct sti_vtg *vtg) > { > @@ -242,7 +241,6 @@ void sti_vtg_set_config(struct sti_vtg *vtg, > else > vtg_enable_irq(vtg); > } > -EXPORT_SYMBOL(sti_vtg_set_config); > > /** > * sti_vtg_get_line_number > @@ -265,7 +263,6 @@ u32 sti_vtg_get_line_number(struct drm_display_mode mode, int y) > > return start_line + y; > } > -EXPORT_SYMBOL(sti_vtg_get_line_number); > > /** > * sti_vtg_get_pixel_number > @@ -281,7 +278,6 @@ u32 sti_vtg_get_pixel_number(struct drm_display_mode mode, int x) > { > return mode.htotal - mode.hsync_start + x; > } > -EXPORT_SYMBOL(sti_vtg_get_pixel_number); > > int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb, > struct drm_crtc *crtc) > @@ -292,7 +288,6 @@ int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb, > vtg->crtc = crtc; > return raw_notifier_chain_register(&vtg->notifier_list, nb); > } > -EXPORT_SYMBOL(sti_vtg_register_client); > > int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb) > { > @@ -301,7 +296,6 @@ int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb) > > return raw_notifier_chain_unregister(&vtg->notifier_list, nb); > } > -EXPORT_SYMBOL(sti_vtg_unregister_client); > > static irqreturn_t vtg_irq_thread(int irq, void *arg) > { >