From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753286AbbJEKkK (ORCPT ); Mon, 5 Oct 2015 06:40:10 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:47563 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbbJEKkG convert rfc822-to-8bit (ORCPT ); Mon, 5 Oct 2015 06:40:06 -0400 X-AuditID: cbfee68f-f796f6d0000014a4-d7-561253843b9b MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <56125384.5030603@samsung.com> Date: Mon, 05 Oct 2015 19:40:04 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , Jacek Anaszewski , Samuel Ortiz , Lee Jones , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux LED Subsystem Subject: Re: [PATCH 1/2] leds: rt5033: add DT binding for RT5033 References: <1443778875-18261-1-git-send-email-ingi2.kim@samsung.com> <1443778875-18261-2-git-send-email-ingi2.kim@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsWyRsSkWLclWCjMYNdVQ4v5R86xWvS/Wchq ce7VSkaL3qvPGS3ufz3KaHF51xw2i61v1jFaLL1+kcliwvS1LBb/9+xgt9i96ymrxeluVgce jzXz1jB6XO7rZfJYufwLm8emVZ1sHneu7WHzmHcy0GPP/B+sHn1bVjF6fN4kF8AZxWWTkpqT WZZapG+XwJXx8O9y1oIfQhULn61mbmC8xNfFyMEhIWAi8WWxfhcjJ5ApJnHh3nq2LkYuDiGB FYwSjcemskMkTCS6b/xigkjMYpR4v3oCK0iCV0BQ4sfkeywgg5gF1CWmTMkFCTMLiEjcffCb GcLWlli28DUzRO8DRomPfQegerUkXn4/xwZiswioSsyeOBUsziagJnFjxUImEFtUIEHi+Nkf YLaIgKLE77ZprCCDmAXeMEssubgNbIOwgIPE2k+TGCE2nGCU+Pu0D2wqp0CwxMrGp2AdEgJT OSQWv9oLtU5A4tvkQywQ/8tKbDrADPGmpMTBFTdYJjCKz0Ly3CyE52YheW4WkucWMLKsYhRN LUguKE5KLzLWK07MLS7NS9dLzs/dxAiM/tP/nvXvYLx7wPoQowAHoxIPr0SSYJgQa2JZcWXu IUZToIMmMkuJJucDU0xeSbyhsZmRhamJqbGRuaWZkjjvQqmfwUIC6YklqdmpqQWpRfFFpTmp xYcYmTg4pRoYxWRmOMxnjnha65j1yNsooPLOZf6L91b9st/kPU1M+uoSYWPHeZ72xSeLS61N dkszMH67MD0jLSzMi1XwnxlPTPXK287BiQITT8r0movfitwttIbj624X2bv7ejelywW/fXG6 e/mJQMlVR4rWrG57dKZy/zFhh+a7vQvm7Mqv+nhORW8ty4QXSizFGYmGWsxFxYkAf5mj8/kC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsVy+t9jQd2WYKEwg0PXtS3mHznHatH/ZiGr xblXKxkteq8+Z7S4//Uoo8XlXXPYLLa+WcdosfT6RSaLCdPXslj837OD3WL3rqesFqe7WR14 PNbMW8Pocbmvl8lj5fIvbB6bVnWyedy5tofNY97JQI8983+wevRtWcXo8XmTXABnVAOjTUZq YkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QyUoKZYk5pUCh gMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjMWLVzIW3BKqeDtxImsD4xa+LkZODgkB E4nuG7+YIGwxiQv31rN1MXJxCAnMYpR4v3oCK0iCV0BQ4sfkeyxdjBwczALyEkcuZUOY6hJT puRClD9glPjYdwCqXEvi5fdzbCA2i4CqxOyJU8HibAJqEjdWLATbJSqQIHH87A8wW0RAUeJ3 2zRWkEHMAm+YJZZc3MYMkhAWcJBY+2kSI8SGE4wSf5/2gU3lFAiWWNn4lHUCI9CZCPfNQrhv FsJ9CxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIEp4tnUjsYD+5yP8QowMGoxMN7 IF4wTIg1say4MvcQowQHs5IIr6WrUJgQb0piZVVqUX58UWlOavEhRlOgBycyS4km5wNTWV5J vKGxiZmRpZG5oYWRsbmSOO+NQwxhQgLpiSWp2ampBalFMH1MHJxSDYxzTNjunF/Hd+dJvuy5 LaevCM+e46Jw91dssVgvb7CKbH7EwuV3cv4fbrrssc2SS0RY1NvuoWdTzEE/5Z4FU7sVUj5d 6X3Ixrp8XUlKjNPb2ja9pZyyDLPmKbkujeisUWPMXNW50jqM31F/y6uj2YxHZU85Fe/43Fyb 9/ePyH7ViXMeBzPXiymxFGckGmoxFxUnAgD6GFz6LQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Rob Herring I'll push ver2 patch soon with your acked because other patch has some issues. Thanks for the review. On 2015년 10월 02일 23:31, Rob Herring wrote: > On Fri, Oct 2, 2015 at 4:41 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for RT5033 flash LEDs. >> >> Signed-off-by: Ingi Kim > > Acked-by: Rob Herring > >> --- >> .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt >> new file mode 100644 >> index 0000000..2ef7bdc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt >> @@ -0,0 +1,38 @@ >> +* Richtek Technology Corporation - RT5033 Flash LED Driver >> + >> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving >> +for torch and strobe applications, it provides an I2C software command >> +to trigger the torch and strobe operation. >> + >> +Required properties: >> +- compatible : Must be "richtek,rt5033-led". >> + >> +A discrete LED element connected to the device must be represented by a child >> +node - see Documentation/devicetree/bindings/leds/common.txt. >> + >> +Required properties of the LED child node: >> + See Documentation/devicetree/bindings/leds/common.txt >> +- led-max-microamp : Minimum Threshold for Timer protection >> + is defined internally (Maximum 200mA). >> +- flash-max-microamp : Flash LED maximum current >> +- flash-max-timeout-us : Flash LED maximum timeout >> + >> +Optional properties of the LED child node: >> +- label : see Documentation/devicetree/bindings/leds/common.txt >> + >> +Example: >> + >> +rt5033 { >> + compatible = "richtek,rt5033"; >> + >> + led { >> + compatible = "richtek,rt5033-led"; >> + >> + flash-led { >> + label = "rt5033-flash"; >> + led-max-microamp = <200000>; >> + flash-max-microamp = <800000>; >> + flash-max-timeout-us = <1216000>; >> + }; >> + }; >> +} >> -- >> 2.0.5 >> >