From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbbJELtJ (ORCPT ); Mon, 5 Oct 2015 07:49:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56947 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbbJELtH (ORCPT ); Mon, 5 Oct 2015 07:49:07 -0400 Subject: Re: [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device To: Mark Rutland , "Gabriel L. Somlo" References: <1443914889-9619-1-git-send-email-somlo@cmu.edu> <20151005100035.GA19064@leverpostej> Cc: gregkh@linuxfoundation.org, paul@pwsan.com, galak@codeaurora.org, will.deacon@arm.com, agross@codeaurora.org, zajec5@gmail.com, hanjun.guo@linaro.org, catalin.marinas@arm.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org, matt.fleming@intel.com, lersek@redhat.com, jordan.l.justen@intel.com, mst@redhat.com, peter.maydell@linaro.org, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, kraxel@redhat.com, qemu-devel@nongnu.org From: Paolo Bonzini Message-ID: <561263A4.2020304@redhat.com> Date: Mon, 5 Oct 2015 13:48:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151005100035.GA19064@leverpostej> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2015 12:00, Mark Rutland wrote: > Some of the keys in the example look like they'd come from other sources > (e.g. the *-tables entries), while others look like kernel/bootloader > configuration options (e.g. etc/boot-fail-wait, bootorder) -- I'm > concerned about redundancy here. The redundancy is because the firmware and the bootloader actually _consume_ these fw_cfg strings to produce the others (the ACPI tables, the kernel configuration options). On the other hand, hiding some strings just because they ought to have been consumed already makes little sense. Paolo