From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbbJENNN (ORCPT ); Mon, 5 Oct 2015 09:13:13 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33742 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbbJENNL (ORCPT ); Mon, 5 Oct 2015 09:13:11 -0400 Subject: Re: [PATCH 8/8] bdc_pci: use PCI_VDEVICE() instead of PCI_DEVICE() To: Greg KH References: <60171155.g7UZoV0Hgv@wasted.cogentembedded.com> <1880175.9DxO9yLYxx@wasted.cogentembedded.com> <20151005031619.GC27303@kroah.com> Cc: linux-usb@vger.kernel.org, balbi@ti.com, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <56127764.8050801@cogentembedded.com> Date: Mon, 5 Oct 2015 16:13:08 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151005031619.GC27303@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/5/2015 6:16 AM, Greg KH wrote: >> Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). > Why? Seemed a good idea to me back in March. :-) > I hate PCI_VDEVICE(), it's impossible to grep for things and does Didn't think about grepping... > not help with readability and is pointless. My one wish was that when I > was the PCI maintainer I would have just deleted the thing from the > kernel entirely instead of leaving it there hoping no one would use it. Thanks for the idea. :-) > I don't like these types of pointless patches, sorry. I hope you don't have the same strong feelings about PCI_DEVICE_SUB(). There's one place (in ohci-pci.c IIRC) it can be used... > thanks, > > greg k-h MBR, Sergei